From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932949AbdHVNPW (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Aug 2017 09:15:22 -0400
Received: from mout.web.de ([212.227.15.4]:64508 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932657AbdHVNPS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Aug 2017 09:15:18 -0400
Subject: Re: [alsa-devel] ALSA: pcsp: Use common error handling code in
 snd_card_pcsp_probe()
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Dan Carpenter <dan.carpenter@oracle.com>
References: <08ee0d6b-788b-2845-6964-e1e55c2d2292@users.sourceforge.net>
 <20170822121625.syvr64kwyh5xjexg@mwanda> <s5hziar9483.wl-tiwai@suse.de>
 <f138ba40-a61f-cdab-3d9b-699dbcacad9d@users.sourceforge.net>
 <s5ho9r792yl.wl-tiwai@suse.de>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <fc4d8c96-7de2-e8f0-4cb4-5dda795d298a@users.sourceforge.net>
Date: Tue, 22 Aug 2017 15:15:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <s5ho9r792yl.wl-tiwai@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:36q0d943lkHWxgKarIzHvXSNWZXrIBJ/1ESKb0JEbcVuKK3HANt
 4B6ZchTIlwuiZKe3v/vI0ETJw+ZdFeSjLo67izNb9QIW5HZXxmZNonALsNrma3v4Nijhvdp
 5dkrkaRbo17R2X6BxZjTFQyjzsg7jmPosg3PztSfbQUVNKJMb9GM3HIeOmBMR6Jp85lzpz+
 rk5n/eAG0hyDUS2j08cRA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:S8xsOwsaW+w=:W2fiCgqoQpQvHLOawyc3YD
 kBMiq19gMzyMC+xlcBZtGBylEu288Sh6tQUxgObHnpvqXf+EcVD/YMuxJEILoG1OdGerZLjvq
 4t8/zP3ihuRFNCYt5QkJ9KfsK5kLI3uqoGewJO3ihMtabevDIvo/BVBHeIoqj0k7eQCjfXwJF
 IkB24OtmTV6tbvCso3rbiyeMYDUfyortNhwfVI4y7hIpUBKsLFYAyyU2vXY7iT+IgdHa2SWII
 KGglZo1dLtvTGe2nkFn+NVluGqHdf+zGlpYgU2KhUzZgpbL4+H40ogT8lDawTg476pW/rtkW7
 RMkWXBREeAo0vHdO2M5Ot0db19iQsOh9DOoa7Nk28j/tQ1cg8hwOEDg2YObYFlXOWSGsalobe
 ji9trGMgzrTgFQWb6HDNVebUfJK5EgKHhYZy2puyDw3xSe1ayOgjHJhol3908MRrPRoyltRtH
 y/5wXMD4DPe3nleWTNI5J3SMD8Hq507Vl1KFD1wFlWZe0uMGY95isI8DDwvHQrJ5lMuZ6aKNV
 ZYxDThQlfeX5gnKstIbS+TZT5sgZVLbNpzlULKqYV68y04UMXaWj2ARK+C/ea2lLZEQJkKxjk
 if6Uxp7M1UfLCM7QerjHxQG83qg8iptq3omJMAB6m7wXOn5/5ECrvc2N6i8LtSsC8MbT7pPPw
 BEXwakvspwnBLfdiVtAA89IyJuBr1ACX8AgfPv1ZX6quBMdzD0elX2OVCXmlMPlQzrRT9IDNC
 llBduVZKZ7jiZXdPlgsTTVhhh8ZecTlEdtU1tqqeZxfS+8+1RnHtnGXp2DW8BpwNew7F1VYe/
 3RYAOq0Y8HQzao0aN0guzGM8zFSCd3c5mEqTdBG6wkExIq6CRwLLK8zgrD2PlMrP39woWEt
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Is it appropriate to treat non-zero values as error codes there generally?
> 
> No, it can't be in general.

I got the impression that the functions which are called at the updated places
by the function “snd_card_pcsp_probe” indicate a successful execution
only by zero so far.


> Lots of functions return a positive value, too.

Would you like to point any example out from the programming interface?

Regards,
Markus