From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A33C0C77B61 for ; Mon, 10 Apr 2023 18:30:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229699AbjDJSaK (ORCPT ); Mon, 10 Apr 2023 14:30:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229626AbjDJSaH (ORCPT ); Mon, 10 Apr 2023 14:30:07 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08D141BEC for ; Mon, 10 Apr 2023 11:30:06 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-7606cf95ab8so2817239f.0 for ; Mon, 10 Apr 2023 11:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1681151405; x=1683743405; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cYKDJKwn10X7KLBuY10/um2m58nz9p5VC59dotIeEO0=; b=FRdjAn56JBxgc+W8+zwgpjOs3Nr2+xBM+V86kQ+EGBTwrajmGuxhQUI/puxV05pZUX Cvtj62XK1mKeWW2jbxDR6jettZuvK6HGogF8sFXdwKaXnwUJqn1O5IVgIjUDDCXBS3EW UQwPhR4S/Av81m64se7slJLAVXyzIqvzRyUa8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681151405; x=1683743405; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cYKDJKwn10X7KLBuY10/um2m58nz9p5VC59dotIeEO0=; b=H08HsjqydHmIRKjOXyDC16KzpEh7P4VpAm5gN7QCCATF7tDNym85eZsgY88sFQyOoG bjmHJ6lqAoyZUZ830A1Ca8j/a+Jwg4+/fxyZAJgu1x2F3HqE/pmWapanPEORPqiDeOpy LOfiT7Sx5jiOLl1Zi4327nPheKsNb0rJgUD34Ck8oi16yz69GkI2zKZ+VQhy7ORiGUCk x8HYyRozkl/e4/blDM3DhlKl506gN7Ea1zoCt8RAL9DGQljrUqCH2m5Nh835jMwdKJQy kbylfiFHPM9L47/R1W5BHOP6tdxEvnuRrqWT9GgduiUTlo7ZVusj41M7b5IYzi6g0jaz 6dmg== X-Gm-Message-State: AAQBX9dO9m+i+Zp8G2jf3kX4pmvE54KMnfuOkA4sVKmSD6rHoWErcv0A PpRJraEseufmA+RcQDSaQ1oodQ== X-Google-Smtp-Source: AKy350aTt/4xClTAoIKpBxclNxt+cGRKJn1lsW7n0DD5/6/9nxr7cWLFWKFlG0cHJgwC7hfmKNtssQ== X-Received: by 2002:a05:6602:13d4:b0:757:f2a2:affa with SMTP id o20-20020a05660213d400b00757f2a2affamr6532981iov.1.1681151405345; Mon, 10 Apr 2023 11:30:05 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id cx4-20020a056638490400b0040bd4f2fcedsm588700jab.105.2023.04.10.11.30.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 11:30:04 -0700 (PDT) Message-ID: Date: Mon, 10 Apr 2023 12:30:04 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 1/3] tools/nolibc/stdio: Implement vprintf() Content-Language: en-US To: paulmck@kernel.org, Willy Tarreau Cc: Mark Brown , Shuah Khan , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20230405-kselftest-nolibc-v2-0-2ac2495814b5@kernel.org> <20230405-kselftest-nolibc-v2-1-2ac2495814b5@kernel.org> From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/23 12:43, Paul E. McKenney wrote: > On Thu, Apr 06, 2023 at 08:26:09PM +0200, Willy Tarreau wrote: >> On Thu, Apr 06, 2023 at 05:19:10PM +0100, Mark Brown wrote: >>> vprintf() is equivalent to vfprintf() to stdout so implement it as a simple >>> wrapper for the existing vfprintf(), allowing us to build kselftest.h. >>> >>> Suggested-by: Willy Tarreau >>> Signed-off-by: Mark Brown >>> --- >>> tools/include/nolibc/stdio.h | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/tools/include/nolibc/stdio.h b/tools/include/nolibc/stdio.h >>> index 96ac8afc5aee..6cbbb52836a0 100644 >>> --- a/tools/include/nolibc/stdio.h >>> +++ b/tools/include/nolibc/stdio.h >>> @@ -273,6 +273,12 @@ int vfprintf(FILE *stream, const char *fmt, va_list args) >>> return written; >>> } >>> >>> +static __attribute__((unused)) >>> +int vprintf(const char *fmt, va_list args) >>> +{ >>> + return vfprintf(stdout, fmt, args); >>> +} >>> + >>> static __attribute__((unused, format(printf, 2, 3))) >>> int fprintf(FILE *stream, const char *fmt, ...) >>> { >> >> Perfect, thank you Mark, I'm glad that it simplified the rest of >> your series. >> >> Acked-by: Willy Tarreau >> >> Paul, feel free to directly queue this one for 6.5. If you prefer I >> can as well queue it on my side and send it later, it's just that I >> have exactly zero extra value on top of this one ;-) > > Alternatively, if it would be more convenient for Mark to send this > up via kselftest: > > Acked-by: Paul E. McKenney > > It currently merges cleanly with the -rcu tree's dev branch, so this > should not be a problem. > > Either way, please let me know, Mark! > > I can take these through kselftest or can go through arm64 Acked-by: Shuah Khan thanks, -- Shuah