From: Aleksa Sarai <asarai@suse.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
Linux Containers <containers@lists.linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] namespaces related fixes for v4.11-rc1
Date: Thu, 23 Feb 2017 13:21:42 +1100 [thread overview]
Message-ID: <fc5d9877-da20-844f-22af-090ffb267a45@suse.de> (raw)
In-Reply-To: <8737f54rue.fsf@xmission.com>
>>> The only known user of this prctl systemd
>>> forks all children after the prctl. So no userspace regressions will
>>> occur.
>>
>> Note that runC and containerd (and thus Docker) as well as cri-o use the prctl
>> as well -- to be able to collect exit codes from a non-child process (namely to
>> collect the exit code from PID 1 in the container).
>
> Are any of those affected by the change? I would not expect so. As it
> would require having children or grand children whose exit codes you
> don't want to collect.
AFAICS they do appear to work (and runC definitely calls the prctl
before it creates the container init process -- so it shouldn't break
anything for runC). I was just pointing out that systemd isn't the only
major userspace user of the prctl (for future reference).
--
Aleksa Sarai
Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/
next prev parent reply other threads:[~2017-02-23 2:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 20:48 [GIT PULL] namespaces related fixes for v4.11-rc1 Eric W. Biederman
2017-02-22 21:15 ` Aleksa Sarai
2017-02-23 1:29 ` Eric W. Biederman
2017-02-23 2:21 ` Aleksa Sarai [this message]
2017-02-23 3:06 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc5d9877-da20-844f-22af-090ffb267a45@suse.de \
--to=asarai@suse.de \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox