From: Shuah Khan <skhan@linuxfoundation.org>
To: David Gow <davidgow@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Brendan Higgins <brendanhiggins@google.com>
Cc: "Guilherme G . Piccoli" <gpiccoli@igalia.com>,
Sebastian Reichel <sre@kernel.org>,
John Ogness <john.ogness@linutronix.de>,
Joe Fradley <joefradley@google.com>,
Daniel Latypov <dlatypov@google.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Aaron Tomlin <atomlin@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-kbuild@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Kees Cook <keescook@chromium.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v6 3/4] kunit: Taint the kernel when KUnit tests are run
Date: Fri, 8 Jul 2022 14:22:14 -0600 [thread overview]
Message-ID: <fc638852-ac9a-abab-8fdb-01b685cdec96@linuxfoundation.org> (raw)
In-Reply-To: <20220708044847.531566-3-davidgow@google.com>
On 7/7/22 10:48 PM, David Gow wrote:
> Make KUnit trigger the new TAINT_TEST taint when any KUnit test is run.
> Due to KUnit tests not being intended to run on production systems, and
> potentially causing problems (or security issues like leaking kernel
> addresses), the kernel's state should not be considered safe for
> production use after KUnit tests are run.
>
> This both marks KUnit modules as test modules using MODULE_INFO() and
> manually taints the kernel when tests are run (which catches builtin
> tests).
>
> Acked-by: Luis Chamberlain <mcgrof@kernel.org>
> Tested-by: Daniel Latypov <dlatypov@google.com>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: David Gow <davidgow@google.com>
> ---
>
> No changes since v5:
> https://lore.kernel.org/linux-kselftest/20220702040959.3232874-3-davidgow@google.com/
>
> No changes since v4:
> https://lore.kernel.org/linux-kselftest/20220701084744.3002019-3-davidgow@google.com/
>
David, Brendan, Andrew,
Just confirming the status of these patches. I applied v4 1/3 and v4 3/4
to linux-kselftest kunit for 5.20-rc1.
I am seeing v5 and v6 now. Andrew applied v5 looks like. Would you like
me to drop the two I applied? Do we have to refresh with v6?
thanks,
-- Shuah
next prev parent reply other threads:[~2022-07-08 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 4:48 [PATCH v6 1/4] panic: Taint kernel if tests are run David Gow
2022-07-08 4:48 ` [PATCH v6 2/4] module: panic: Taint the kernel when selftest modules load David Gow
2022-07-08 4:48 ` [PATCH v6 3/4] kunit: Taint the kernel when KUnit tests are run David Gow
2022-07-08 20:22 ` Shuah Khan [this message]
2022-07-08 21:00 ` Daniel Latypov
2022-07-08 21:22 ` Shuah Khan
2022-07-08 21:24 ` Shuah Khan
2022-07-09 3:35 ` David Gow
2022-07-11 23:17 ` Shuah Khan
2022-07-08 4:48 ` [PATCH v6 4/4] selftest: Taint kernel when test module loaded David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc638852-ac9a-abab-8fdb-01b685cdec96@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=atomlin@redhat.com \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@linux.intel.com \
--cc=joefradley@google.com \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox