Re: [PATCH v2 1/2] dt-bindings: display: ti,am65x-dss: Add support for AM62L DSS

[Devarsh Thakkar <devarsht@ti.com>]

Hi Tomi,

Thanks for the review.
On 04/02/25 19:25, Tomi Valkeinen wrote:
<snip>
>>     description: |
>> -  The AM625 and AM65x TI Keystone Display SubSystem with two output
>> +  The AM625 and AM65x TI Keystone Display SubSystem has two output
>>     ports and two video planes. In AM65x DSS, the first video port
>>     supports 1 OLDI TX and in AM625 DSS, the first video port output is
>>     internally routed to 2 OLDI TXes. The second video port supports DPI
>>     format. The first plane is full video plane with all features and the
>>     second is a "lite plane" without scaling support.
>> +  The AM62A7 display subsystem has a single output port supporting DPI format
>> +  although similar to AM625 and AM65x Socs, it has two video planes where
>> first
>> +  is full video plane with all features and second is a video "lite" plane
>> which
>> +  does not support scaling.
> 
> The part above doesn't belong into "add AM62L" patch. It's also quite
> confusing. "although similar to..."? Maybe drop the text "although similar to
> AM625 and AM65x Socs, ", and start a new sentence from "it"?
> 

Sure, I will split the patch for AM62A and correct above too.

> For the AM62L parts:
> 
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> 
>  Tomi

Regards
Devarsh