From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751188AbdFARzk (ORCPT ); Thu, 1 Jun 2017 13:55:40 -0400 Received: from mout.web.de ([212.227.15.3]:60450 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751108AbdFARzi (ORCPT ); Thu, 1 Jun 2017 13:55:38 -0400 To: linux-arm-kernel@lists.infradead.org, Russell King , Sylvain Lemieux , Vladimir Zapolskiy Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ARM: lpc32xx: Delete an error message for a failed memory allocation in lpc32xx_pm_enter() Message-ID: Date: Thu, 1 Jun 2017 19:55:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:gB7BFxA+cnPggkm9Bm5UAFPdtg7jO5z7xCdUCsa2QxJwmCegzZG 2ckTvCHh46F3FNoDfiFH5f0dUWOOCepdDEtsKp25isyqDE9VaO7iNALNdbFuPlJ7mbRoTpQ NyEik4gD5oREvapwUutv93JmMf0yzAta6VtEBFaRQnhBbfRlVc33Kxo16ZZFuU60zekBhk/ yG9FlKV1EGJu84elJy7pA== X-UI-Out-Filterresults: notjunk:1;V01:K0:qouO11b1N6E=:hNFlydd/D/NLrSk5nEM8F6 ASuFe2TPNkPNKSIzDeKRib6FP0F5E0zl/JXdQlB+oB6fGOpNKDXeZqgVVx6sXL/2xctubHyIl ldM+Ys7Y6uQ6B73kDrxuRLp9jegqzuz8QIkGP7fDgqDCmBiwzMXe7bLPorMGTtKuq6X6W8Dsx cME0WtiXR+GsD3P5sDIAwYC8p2hbbskOhClIEpNpm7cFBGXkFs4iMMwU3sf6y31LrZW82hXjn 7kP/dOHPa37uS9ncK7u+UZQ/TFoJzUdJgeTcncnyofbXW0QcWHQZEKEpYbQvzJlJMHCGGfco1 rvkQDqARoP/MQofHtixxi+LkjmzMAPXV3m3Ob2Md94yzsKkLSefEoZ4kbEyfThQc6uhVzNGcO 0gRXlmGjNjXGHg4/JsFd32J8omfoxptwTPWcfhRZYG4Dw9LCeyfDgCnR1YUCfne7GJ23JjJ4l cus5611tQvsjJXyLQv/QVdpneYiVHmD8MrHGM7iRLxkbItyg7Eu/75D9AiN6rZpkgeg4DuI9C n4tX9EOCORSYXVtqM1fy5O1/GH/+Hn+BIyodC6WyRJZMUR6y8StsfQipi9nL9Ryjc+mq7UHDQ i4QnRO0duh4r7bfQmsMDw4M7IBNxi+kmoH5xokketMRjTHs4N5m8T0a85y9NP84CbzpE/NPjm cAO3I7JnHTeKjw3WkMn5mb9yOHbqunkES0ACp9EP1GO+Cp9hnKu8WEkbR8lNNNCBToqFZCUlH xlw64BOhuIODlGYwyj8sV4KQmXrdvsszAayaH4jtQn73jbyaS34G6apgPIcO/gmG6+jk+jLv+ hj3S25Q Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 1 Jun 2017 19:50:32 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- arch/arm/mach-lpc32xx/pm.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/arm/mach-lpc32xx/pm.c b/arch/arm/mach-lpc32xx/pm.c index 62471570d586..5a4d31488d11 100644 --- a/arch/arm/mach-lpc32xx/pm.c +++ b/arch/arm/mach-lpc32xx/pm.c @@ -87,12 +87,8 @@ static int lpc32xx_pm_enter(suspend_state_t state) /* Allocate some space for temporary IRAM storage */ iram_swap_area = kmalloc(lpc32xx_sys_suspend_sz, GFP_KERNEL); - if (!iram_swap_area) { - printk(KERN_ERR - "PM Suspend: cannot allocate memory to save portion " - "of SRAM\n"); + if (!iram_swap_area) return -ENOMEM; - } /* Backup a small area of IRAM used for the suspend code */ memcpy(iram_swap_area, (void *) TEMP_IRAM_AREA, -- 2.13.0