Re: [PATCH] staging: gpib: use int instead of u32 to store error codes

[Qianfeng Rong <rongqianfeng@vivo.com>]

在 2025/8/26 18:19, Dan Carpenter 写道:
> On Tue, Aug 26, 2025 at 05:58:59PM +0800, Qianfeng Rong wrote:
>> Use int instead of size_t for 'ret' variable to store negative error codes
>> returned by bb_write().
>>
> The commit message needs to give a motivation.  I would have assumed from
> reading the patch that this caused a signedness bug but it doesn't.
> The commit has no effect on runtime but fixing the type is a nice
> cleanup.  My commit message would say:
>
> The "ret" variable is used to store the return from bb_write() returns
> either zero on success or negative error codes on failure.  Storing the
> error codes in size_t which is an unsigned long, doesn't cause an issue
> at runtime but it's ugly as pants.  Change "ret" from size_t to int
> type.  No effect on runtime.


Thanks very much for the detailed comments.  I will send v2 with a commit
message similar to the one you suggested.

Best regards,
Qianfeng