From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8872F3CD8B5 for ; Wed, 5 Aug 2026 22:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785970029; cv=none; b=DefTq2DoivHO0x0i1I9aOpgxgCMSVa8THzI+5/Ts911ugYtuExbQNG6eVyWkzS1xaTkRhqOv/28PKmxC0lT6r6QLVv/dh1dahQmMAY6HdRiulslaEu6oXjqYHhEXjZJXk+63Eylujd6aNyOvNPSttE68Cu9VKgiSTcY48XAv+Rg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785970029; c=relaxed/simple; bh=tjdzdLFkZVKGtTo2zBikuIhYnL4wvZrqsoX8pP/mdAo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=bsJ5kwW2GnR8N8h4YJazCGV8hjzD4Fk1UBpQcBouCuKIHCGtpdxr+YZhiWA6ruNkgRef8FMp6EoRex4rV2uXQlqveMoZyhmRVGJpvGqxSHK3Yu0taOZBz7A1YHwV9ZxNiHGyMETjmqAxR1WJhx6BYRncb8xDuKsVWN6E9o0fXGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cz/Epjzl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cz/Epjzl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 636D81F000E9; Wed, 5 Aug 2026 22:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785970028; bh=fuuPEvAgsHQj9nsqLXSKpXJzZS7FnT2ffJxVGZb1cbA=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=cz/EpjzlrGUmxt+B0JJyEawyTl6rwJbKaxw6SkzKrj6S4yhYdGRNOsyxG2x4OD+jl yWCl4Kn26ujSZrB0Oh9FFklTurJ4MoF0dPRBOdv2DlbjGh02l/1jRlzTIR/8zcAFKH X2RZjl4NkdVKGtKl956zpqWN+23Io66ZlMChieQl4BWxpMmrYgBOlLfswWvmXtqudT MIdXFKwZwxG2Txe9XbdjsucTEQsEXoUrpzNQeIwZSBah2SZ/KSaz1quHzm/vTWiitT wH2+yCcRQ6hpDUI4CJq+YTeu0AfftbUJeEjDpUfK88+t+FJB98hG8kFu9FUgZOJbTE TXdV3qAiKby0w== Date: Wed, 5 Aug 2026 15:47:06 -0700 (PDT) From: Stefano Stabellini To: Juergen Gross cc: linux-kernel@vger.kernel.org, Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Subject: Re: [PATCH 3/4] xen: Drop CONFIG_XEN_AUTO_XLATE In-Reply-To: <20260805082137.1214967-4-jgross@suse.com> Message-ID: References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-4-jgross@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 5 Aug 2026, Juergen Gross wrote: > CONFIG_XEN_AUTO_XLATE is referenced only in code built with CONFIG_XEN > enabled. As it is enabled for all architectures supporting Xen, it can > be just dropped. > > Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini > --- > drivers/xen/Kconfig | 6 ------ > drivers/xen/Makefile | 2 +- > drivers/xen/privcmd.c | 4 ++-- > include/xen/xen-ops.h | 22 ---------------------- > 4 files changed, 3 insertions(+), 31 deletions(-) > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index cfb517cd77dc..32e35a8580ee 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -309,12 +309,6 @@ config XEN_EFI > def_bool y > depends on (ARM || ARM64 || X86_64) && EFI > > -config XEN_AUTO_XLATE > - def_bool y > - depends on ARM || ARM64 || X86 > - help > - Support for auto-translated physmap guests. > - > config XEN_ACPI > def_bool y > depends on X86 && ACPI > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > index c0503f1c7d5b..6ce2e2a52d47 100644 > --- a/drivers/xen/Makefile > +++ b/drivers/xen/Makefile > @@ -2,6 +2,7 @@ > obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o > obj-y += grant-table.o features.o balloon.o manage.o time.o > obj-y += mem-reservation.o > +obj-y += xlate_mmu.o > obj-y += events/ > obj-y += xenbus/ > > @@ -29,7 +30,6 @@ obj-$(CONFIG_XEN_PRIVCMD) += xen-privcmd.o > obj-$(CONFIG_XEN_ACPI_PROCESSOR) += xen-acpi-processor.o > obj-$(CONFIG_XEN_EFI) += efi.o > obj-$(CONFIG_XEN_SCSI_BACKEND) += xen-scsiback.o > -obj-$(CONFIG_XEN_AUTO_XLATE) += xlate_mmu.o > obj-$(CONFIG_XEN_PVCALLS_BACKEND) += pvcalls-back.o > obj-$(CONFIG_XEN_PVCALLS_FRONTEND) += pvcalls-front.o > xen-evtchn-y := evtchn.o > diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c > index 725a49a0eee7..7cfc28f1bb86 100644 > --- a/drivers/xen/privcmd.c > +++ b/drivers/xen/privcmd.c > @@ -794,7 +794,7 @@ static long privcmd_ioctl_mmap_resource(struct file *file, > goto out; > } > > - if (IS_ENABLED(CONFIG_XEN_AUTO_XLATE) && !xen_pv_domain()) { > + if (!xen_pv_domain()) { > unsigned int nr = DIV_ROUND_UP(kdata.num, XEN_PFN_PER_PAGE); > struct page **pages; > unsigned int i; > @@ -825,7 +825,7 @@ static long privcmd_ioctl_mmap_resource(struct file *file, > if (rc) > goto out; > > - if (IS_ENABLED(CONFIG_XEN_AUTO_XLATE) && !xen_pv_domain()) { > + if (!xen_pv_domain()) { > rc = xen_remap_vma_range(vma, kdata.addr, kdata.num << PAGE_SHIFT); > } else { > unsigned int domid = > diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h > index 496e6013c689..15e0c3f4b7bb 100644 > --- a/include/xen/xen-ops.h > +++ b/include/xen/xen-ops.h > @@ -59,7 +59,6 @@ static inline int xen_remap_pfn(struct vm_area_struct *vma, unsigned long addr, > > struct vm_area_struct; > > -#ifdef CONFIG_XEN_AUTO_XLATE > int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, > unsigned long addr, > xen_pfn_t *gfn, int nr, > @@ -68,27 +67,6 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, > struct page **pages); > int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma, > int nr, struct page **pages); > -#else > -/* > - * These two functions are called from arch/x86/xen/mmu.c and so stubs > - * are needed for a configuration not specifying CONFIG_XEN_AUTO_XLATE. > - */ > -static inline int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, > - unsigned long addr, > - xen_pfn_t *gfn, int nr, > - int *err_ptr, pgprot_t prot, > - unsigned int domid, > - struct page **pages) > -{ > - return -EOPNOTSUPP; > -} > - > -static inline int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma, > - int nr, struct page **pages) > -{ > - return -EOPNOTSUPP; > -} > -#endif > > int xen_remap_vma_range(struct vm_area_struct *vma, unsigned long addr, > unsigned long len); > -- > 2.55.0 >