From: "Lendacky, Thomas" <Thomas.Lendacky@amd.com>
To: Tim Chen <tim.c.chen@linux.intel.com>,
Jiri Kosina <jikos@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
David Woodhouse <dwmw@amazon.co.uk>,
Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Casey Schaufler <casey.schaufler@intel.com>,
Asit Mallick <asit.k.mallick@intel.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Jon Masters <jcm@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 0/2] Provide options to enable spectre_v2 userspace-userspace protection
Date: Fri, 21 Sep 2018 17:44:54 +0000 [thread overview]
Message-ID: <fce1f42f-cbca-c715-d281-3bb0933a1592@amd.com> (raw)
In-Reply-To: <f0308518-6444-815a-cdcf-9e7d43887727@linux.intel.com>
On 09/21/2018 12:14 PM, Tim Chen wrote:
> On 09/21/2018 08:44 AM, Lendacky, Thomas wrote:
>
>
>> + if (static_cpu_has(X86_FEATURE_SSBD))
>> + x86_spec_ctrl_base |= ssbd_tif_to_spec_ctrl(tifn);
>> +
>> + x86_spec_ctrl_base |= stibp_tif_to_spec_ctrl(tifn);
>>
>> wrmsrl(MSR_IA32_SPEC_CTRL, msr);
>> }
>>
>
> Should this part be s/x86_spec_ctrl_base/msr/ ?
Yup, I messed up. Those should "msr |=", not x86_spec_ctrl_base.
Thanks,
Tom
>
> Tim
>
prev parent reply other threads:[~2018-09-21 17:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 21:35 [PATCH 0/2] Provide options to enable spectre_v2 userspace-userspace protection Tim Chen
2018-09-19 21:35 ` [PATCH 1/2] x86/speculation: Option to select app to app mitigation for spectre_v2 Tim Chen
2018-09-19 21:35 ` [PATCH 2/2] x86/speculation: Provide application property based STIBP protection Tim Chen
2018-09-20 7:57 ` Peter Zijlstra
2018-09-20 17:17 ` Tim Chen
2018-09-20 8:00 ` Peter Zijlstra
2018-09-20 17:32 ` Tim Chen
2018-10-02 15:41 ` Jon Masters
2018-10-02 15:43 ` Jiri Kosina
2018-10-02 15:44 ` Jon Masters
2018-09-20 21:38 ` [PATCH 0/2] Provide options to enable spectre_v2 userspace-userspace protection Lendacky, Thomas
2018-09-21 15:44 ` Lendacky, Thomas
2018-09-21 17:14 ` Tim Chen
2018-09-21 17:44 ` Lendacky, Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fce1f42f-cbca-c715-d281-3bb0933a1592@amd.com \
--to=thomas.lendacky@amd.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=asit.k.mallick@intel.com \
--cc=casey.schaufler@intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw@amazon.co.uk \
--cc=jcm@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox