From: Yisheng Xie <xieyisheng1@huawei.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: <akpm@linux-foundation.org>, <minchan@kernel.org>,
<ngupta@vflare.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] zram: fix compr_data_size stat
Date: Fri, 11 Aug 2017 11:00:49 +0800 [thread overview]
Message-ID: <fce532a8-eef7-22c1-e60d-e02901299d39@huawei.com> (raw)
In-Reply-To: <d0ef1425-ef1b-f92e-4b51-2432aac570c4@huawei.com>
On 2017/8/11 10:07, Yisheng Xie wrote:
>
>
> On 2017/8/11 9:38, Sergey Senozhatsky wrote:
>> On (08/11/17 10:35), Sergey Senozhatsky wrote:
>>> On (08/11/17 09:10), Yisheng Xie wrote:
>>>> The compr_data_size is a stat for compressed size of pages stored, which
>>>> should add comp_len when we compresse a page.
>>>>
>>>> Meanwhile fix typos in comment:
>>>> * ZRAM_SAME means page consists the same element not the entirely zero page
>>>> * read_from_bdev_async() return 1 to avoid call page_endio() in zram_rw_page()
>>>>
>>>> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
>>>
>>> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>>
>> seems that some of the changes can be folded into the existing -next patches.
>
> Yes, feel free to fold it :)
>
> I find Minchan is removing zram_rw_page(), so maybe the return value of
> read_from_bdev_async and write_to_bdev can be re-writed, it seems we need to
I mean no need to (sorry for typo.)
> call page_endio() depend these return value anymore, after delete zram_rw_page().
>
> Thanks
> Yisheng Xie
>
>
> .
>
next prev parent reply other threads:[~2017-08-11 3:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 1:10 [PATCH -next] zram: fix compr_data_size stat Yisheng Xie
2017-08-11 1:35 ` Sergey Senozhatsky
2017-08-11 1:38 ` Sergey Senozhatsky
2017-08-11 2:07 ` Yisheng Xie
2017-08-11 3:00 ` Yisheng Xie [this message]
2017-08-14 8:08 ` Minchan Kim
2017-08-14 9:24 ` Yisheng Xie
2017-08-14 9:34 ` Minchan Kim
2017-08-14 10:53 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fce532a8-eef7-22c1-e60d-e02901299d39@huawei.com \
--to=xieyisheng1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox