From: Josua Mayer <josua@solid-run.com>
To: Peter Rosin <peda@axentia.se>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Andreas Kemnade <andreas@kemnade.info>,
Kevin Hilman <khilman@baylibre.com>,
Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Vignesh R <vigneshr@ti.com>, Andi Shyti <andi.shyti@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Yazan Shhady <yazan.shhady@solid-run.com>,
Jon Nettleton <jon@solid-run.com>,
Mikhail Anikin <mikhail.anikin@solid-run.com>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v9 3/7] mux: add help text for MULTIPLEXER config option
Date: Mon, 9 Feb 2026 11:31:31 +0000 [thread overview]
Message-ID: <fcef2798-1645-41fb-952e-daf3657bc231@solid-run.com> (raw)
In-Reply-To: <bc5fbfc5-6f71-eeed-ad90-0c1b835e65ea@axentia.se>
Hi Peter,
On 09/02/2026 13:10, Peter Rosin wrote:
> Hi!
>
> 2026-02-08 at 16:38, Josua Mayer wrote:
>> Add prompt and help text for CONFIG_MULTIPLEXER to allow enabling this
>> option thorugh the kernel configuration without explicit "select" driver
>> dependencies.
>>
>> Select it by default when COMPILE_TEST is set for better coverage.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> ---
>> drivers/mux/Kconfig | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig
>> index c68132e38138..4f7c6bb86fc6 100644
>> --- a/drivers/mux/Kconfig
>> +++ b/drivers/mux/Kconfig
>> @@ -4,7 +4,14 @@
>> #
>>
>> config MULTIPLEXER
>> - tristate
>> + tristate "Generic Multiplexer Support"
>> + default m if COMPILE_TEST
>> + help
>> + This framework is designed to abstract multiplexer handling for
>> + devices via various GPIO-, MMIO/Regmap or specific multiplexer
>> + controller chips.
>> +
>> + If unsure, say no.
>>
>> menu "Multiplexer drivers"
>> depends on MULTIPLEXER
>>
> I'm not comfortable with making MULTIPLEXER a visible symbol. It is meant to
> be selected when needed (and there are a dozen or so instances). The kbuild
> docs has this on the subject:
>
> "In general use select only for non-visible symbols (no prompts
> anywhere) and for symbols with no dependencies."
The patch description didn't make the decision logic clear,
and I plan to submit a standalone patch for this after v7.0-rc1.
Basically existing drivers using mux core used "select" to enable it,
even though the core can function standalone with device-tree.
Some of these users (phy-can-transceiver) function perfectly
perfectly fine without mux, and use it as an optional feature.
Likely drivers only used "select" to avoid writing helper functions,
prompt, kconfig description and stubs - which this patch-set added.
So I will argue that some existing users relying on "select" was wrong,
and that the mux framework is generally useful on its own.
next prev parent reply other threads:[~2026-02-09 11:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 15:38 [PATCH v9 0/7] mmc: host: renesas_sdhi_core: support configuring an optional sdio mux Josua Mayer
2026-02-08 15:38 ` [PATCH v9 1/7] phy: can-transceiver: rename temporary helper function to avoid conflict Josua Mayer
2026-02-12 16:48 ` Vladimir Oltean
2026-02-12 16:53 ` Geert Uytterhoeven
2026-02-16 8:19 ` Josua Mayer
2026-02-16 9:29 ` Vladimir Oltean
2026-02-16 10:01 ` Geert Uytterhoeven
2026-02-16 15:24 ` Andreas Kemnade
2026-02-23 12:43 ` Josua Mayer
2026-02-23 13:12 ` Vladimir Oltean
2026-02-23 13:44 ` Ulf Hansson
2026-02-08 15:38 ` [PATCH v9 2/7] mux: Add helper functions for getting optional and selected mux-state Josua Mayer
2026-02-08 15:38 ` [PATCH v9 3/7] mux: add help text for MULTIPLEXER config option Josua Mayer
2026-02-09 8:10 ` Geert Uytterhoeven
2026-02-09 11:10 ` Peter Rosin
2026-02-09 11:31 ` Josua Mayer [this message]
2026-02-09 11:43 ` Peter Rosin
2026-02-09 12:07 ` Josua Mayer
2026-02-09 13:08 ` Peter Rosin
2026-02-09 20:02 ` Josua Mayer
2026-02-10 14:42 ` Peter Rosin
2026-02-10 7:50 ` Geert Uytterhoeven
2026-02-10 14:45 ` Peter Rosin
2026-02-08 15:38 ` [PATCH v9 4/7] phy: can-transceiver: drop temporary helper getting optional mux-state Josua Mayer
2026-02-08 15:39 ` [PATCH v9 5/7] i2c: omap: switch to new generic helper for getting selected mux-state Josua Mayer
2026-02-08 15:39 ` [PATCH v9 6/7] dt-bindings: mmc: renesas,sdhi: Add mux-states property Josua Mayer
2026-02-08 15:39 ` [PATCH v9 7/7] mmc: host: renesas_sdhi_core: support selecting an optional mux Josua Mayer
2026-02-09 2:12 ` kernel test robot
2026-02-09 9:57 ` [PATCH v9 0/7] mmc: host: renesas_sdhi_core: support configuring an optional sdio mux Ulf Hansson
2026-02-09 10:21 ` Josua Mayer
2026-02-09 13:16 ` Peter Rosin
2026-02-09 13:39 ` Ulf Hansson
2026-02-09 13:50 ` Peter Rosin
2026-02-09 16:48 ` Ulf Hansson
2026-02-09 16:49 ` Ulf Hansson
2026-02-09 18:42 ` Josua Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcef2798-1645-41fb-952e-daf3657bc231@solid-run.com \
--to=josua@solid-run.com \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jmkrzyszt@gmail.com \
--cc=jon@solid-run.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mailhol@kernel.org \
--cc=mikhail.anikin@solid-run.com \
--cc=mkl@pengutronix.de \
--cc=neil.armstrong@linaro.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yazan.shhady@solid-run.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox