From: "Sapkal, Swapnil" <swapnil.sapkal@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: <mingo@redhat.com>, <acme@kernel.org>, <namhyung@kernel.org>,
<irogers@google.com>, <james.clark@arm.com>,
<ravi.bangoria@amd.com>, <yu.c.chen@intel.com>,
<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
<jolsa@kernel.org>, <rostedt@goodmis.org>,
<vincent.guittot@linaro.org>, <adrian.hunter@intel.com>,
<kan.liang@linux.intel.com>, <gautham.shenoy@amd.com>,
<kprateek.nayak@amd.com>, <juri.lelli@redhat.com>,
<yangjihong@bytedance.com>, <void@manifault.com>, <tj@kernel.org>,
<vineethr@linux.ibm.com>, <linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>, <santosh.shukla@amd.com>,
<ananth.narayan@amd.com>, <sandipan.das@amd.com>,
James Clark <james.clark@linaro.org>
Subject: Re: [PATCH v2 1/6] sched/stats: Print domain name in /proc/schedstat
Date: Mon, 25 Nov 2024 18:01:16 +0530 [thread overview]
Message-ID: <fcefeb4d-3acb-462d-9c9b-3df8d927e522@amd.com> (raw)
In-Reply-To: <20241122111253.GR24774@noisy.programming.kicks-ass.net>
Hello Peter,
On 11/22/2024 4:42 PM, Peter Zijlstra wrote:
> On Fri, Nov 22, 2024 at 08:44:47AM +0000, Swapnil Sapkal wrote:
>
>> schedstat version has not been updated since this change merely adds
>> additional information to the domain name field and does not add a new
>> field altogether.
>
> So I don't care much either way, but if an existing tool is trying to
> parse the domain number, it might now get confused by the extra
> characters. I know of no such tool, just being pedantic.
I will change the schedstat version so that it will not break any
existing tools.
However the domain name is under CONFIG_SCHED_DEBUG and thus
incrementing the schedstats version is not sufficient when this config
option is disabled. Is it okay for you to move domain name out of
CONFIG_SCHED_DEBUG?
Previously, I sent couple of patches to change the schedstat layout for
* Correctly accounting the different types of imbalances [1]
* Accurately computing the task hot migrations [2] (This was your patch)
I would like to include these two patches that better helps justify the
version change. Is that okay by you?
[1]
https://lore.kernel.org/all/20240514044445.1409976-1-swapnil.sapkal@amd.com/
[2]
https://lore.kernel.org/all/20230614102224.12555-1-swapnil.sapkal@amd.com/
--
Thanks and Regards,
Swapnil
next prev parent reply other threads:[~2024-11-25 12:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 8:44 [PATCH v2 0/6] perf sched: Introduce stats tool Swapnil Sapkal
2024-11-22 8:44 ` [PATCH v2 1/6] sched/stats: Print domain name in /proc/schedstat Swapnil Sapkal
2024-11-22 8:55 ` [sos-linux-ext-patches] " Sapkal, Swapnil
2024-11-22 11:08 ` Peter Zijlstra
2024-11-25 3:47 ` Sapkal, Swapnil
2024-11-22 11:12 ` Peter Zijlstra
2024-11-25 12:31 ` Sapkal, Swapnil [this message]
2024-11-25 13:41 ` Peter Zijlstra
2024-11-22 8:44 ` [PATCH v2 2/6] perf sched stats: Add record and rawdump support Swapnil Sapkal
2024-11-22 8:44 ` [PATCH v2 3/6] perf sched stats: Add schedstat v16 support Swapnil Sapkal
2024-11-22 8:44 ` [PATCH v2 4/6] perf sched stats: Add support for report subcommand Swapnil Sapkal
2024-11-22 8:44 ` [PATCH v2 5/6] perf sched stats: Add support for live mode Swapnil Sapkal
2024-11-22 8:44 ` [PATCH v2 6/6] perf sched stats: Add support for diff subcommand Swapnil Sapkal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcefeb4d-3acb-462d-9c9b-3df8d927e522@amd.com \
--to=swapnil.sapkal@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=rostedt@goodmis.org \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vineethr@linux.ibm.com \
--cc=void@manifault.com \
--cc=yangjihong@bytedance.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox