* [PATCH v2] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances
@ 2025-07-08 11:39 Hrushikesh Salunke
2025-07-11 4:33 ` Siddharth Vadapalli
2025-07-15 5:28 ` Vignesh Raghavendra
0 siblings, 2 replies; 3+ messages in thread
From: Hrushikesh Salunke @ 2025-07-08 11:39 UTC (permalink / raw)
To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt
Cc: s-vadapalli, linux-arm-kernel, devicetree, linux-kernel,
h-salunke, danishanwar
In AM69 SoC there are 4 instances of the 4 lane SERDES. So in
"serdes_ln_ctrl" node there are total 16 entries in "mux-reg-mask"
property. But "idle-states" is defined only for the lanes of first two
SERDES instances. SERDES lane mapping is left at its reset state of
"zero" for all four lanes of SERDES2 and SERDES4. The reset state of
"zero" corresponds to the following configuration:
Lanes 0 and 1 of SERDES2 are unused
CPSW MAC Ports 1 and 2 mapped to lanes 2 and 3 of SERDES2
EDP Lanes 0, 1, 2 and 3 mapped to lanes 0, 1, 2 and 3 of SERDES4
For completeness, define the "idle-states" for the lanes of remaining
SERDES instances.
Signed-off-by: Hrushikesh Salunke <h-salunke@ti.com>
---
This patch is based on commit
26ffb3d6f02c Add linux-next specific files for 20250704
Changes since v1
As pointed by out by Siddharth, setting lanes of remaining SERDES
to "unused" will cause regression on AM69-SK as these lanes are used
by CPSW and Display. Updated patch to set the desired values for
remaining serdes lanes.
Rebased on current next.
v1: https://lore.kernel.org/all/20250609115921.2380611-1-h-salunke@ti.com/
arch/arm64/boot/dts/ti/k3-am69-sk.dts | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
index f28375629739..e803fa139b73 100644
--- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
@@ -1294,8 +1294,12 @@ partition@3fc0000 {
&serdes_ln_ctrl {
idle-states = <J784S4_SERDES0_LANE0_PCIE1_LANE0>, <J784S4_SERDES0_LANE1_PCIE1_LANE1>,
<J784S4_SERDES0_LANE2_PCIE3_LANE0>, <J784S4_SERDES0_LANE3_USB>,
- <J784S4_SERDES1_LANE0_PCIE0_LANE0>, <J784S4_SERDES1_LANE1_PCIE0_LANE1>,
- <J784S4_SERDES1_LANE2_PCIE0_LANE2>, <J784S4_SERDES1_LANE3_PCIE0_LANE3>;
+ <J784S4_SERDES1_LANE0_PCIE0_LANE0>, <J784S4_SERDES1_LANE1_PCIE0_LANE1>,
+ <J784S4_SERDES1_LANE2_PCIE0_LANE2>, <J784S4_SERDES1_LANE3_PCIE0_LANE3>,
+ <J784S4_SERDES2_LANE0_IP2_UNUSED>, <J784S4_SERDES2_LANE1_IP2_UNUSED>,
+ <J784S4_SERDES2_LANE2_QSGMII_LANE1>, <J784S4_SERDES2_LANE3_QSGMII_LANE2>,
+ <J784S4_SERDES4_LANE0_EDP_LANE0>, <J784S4_SERDES4_LANE1_EDP_LANE1>,
+ <J784S4_SERDES4_LANE2_EDP_LANE2>, <J784S4_SERDES4_LANE3_EDP_LANE3>;
};
&serdes_wiz0 {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances
2025-07-08 11:39 [PATCH v2] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances Hrushikesh Salunke
@ 2025-07-11 4:33 ` Siddharth Vadapalli
2025-07-15 5:28 ` Vignesh Raghavendra
1 sibling, 0 replies; 3+ messages in thread
From: Siddharth Vadapalli @ 2025-07-11 4:33 UTC (permalink / raw)
To: Hrushikesh Salunke
Cc: nm, vigneshr, kristo, robh, krzk+dt, conor+dt, s-vadapalli,
linux-arm-kernel, devicetree, linux-kernel, danishanwar
On Tue, Jul 08, 2025 at 05:09:42PM +0530, Hrushikesh Salunke wrote:
> In AM69 SoC there are 4 instances of the 4 lane SERDES. So in
> "serdes_ln_ctrl" node there are total 16 entries in "mux-reg-mask"
> property. But "idle-states" is defined only for the lanes of first two
> SERDES instances. SERDES lane mapping is left at its reset state of
> "zero" for all four lanes of SERDES2 and SERDES4. The reset state of
> "zero" corresponds to the following configuration:
>
> Lanes 0 and 1 of SERDES2 are unused
> CPSW MAC Ports 1 and 2 mapped to lanes 2 and 3 of SERDES2
> EDP Lanes 0, 1, 2 and 3 mapped to lanes 0, 1, 2 and 3 of SERDES4
>
> For completeness, define the "idle-states" for the lanes of remaining
> SERDES instances.
>
> Signed-off-by: Hrushikesh Salunke <h-salunke@ti.com>
> ---
> This patch is based on commit
> 26ffb3d6f02c Add linux-next specific files for 20250704
>
> Changes since v1
> As pointed by out by Siddharth, setting lanes of remaining SERDES
> to "unused" will cause regression on AM69-SK as these lanes are used
> by CPSW and Display. Updated patch to set the desired values for
> remaining serdes lanes.
Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Regards,
Siddharth.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances
2025-07-08 11:39 [PATCH v2] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances Hrushikesh Salunke
2025-07-11 4:33 ` Siddharth Vadapalli
@ 2025-07-15 5:28 ` Vignesh Raghavendra
1 sibling, 0 replies; 3+ messages in thread
From: Vignesh Raghavendra @ 2025-07-15 5:28 UTC (permalink / raw)
To: nm, kristo, robh, krzk+dt, conor+dt, Hrushikesh Salunke
Cc: Vignesh Raghavendra, s-vadapalli, linux-arm-kernel, devicetree,
linux-kernel, danishanwar
Hi Hrushikesh Salunke,
On Tue, 08 Jul 2025 17:09:42 +0530, Hrushikesh Salunke wrote:
> In AM69 SoC there are 4 instances of the 4 lane SERDES. So in
> "serdes_ln_ctrl" node there are total 16 entries in "mux-reg-mask"
> property. But "idle-states" is defined only for the lanes of first two
> SERDES instances. SERDES lane mapping is left at its reset state of
> "zero" for all four lanes of SERDES2 and SERDES4. The reset state of
> "zero" corresponds to the following configuration:
>
> [...]
I have applied the following to branch ti-k3-dts-next on [1].
Thank you!
[1/1] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances
commit: 974e6cfd8d7b61c3fa27a9dd6ed452b7e7a06de9
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-15 5:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-08 11:39 [PATCH v2] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances Hrushikesh Salunke
2025-07-11 4:33 ` Siddharth Vadapalli
2025-07-15 5:28 ` Vignesh Raghavendra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).