From: David Laight <David.Laight@ACULAB.COM>
To: 'Joe Perches' <joe@perches.com>,
Alex Shi <alex.shi@linux.alibaba.com>,
"andrew@lunn.ch" <andrew@lunn.ch>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] net/dsa: remove unused macros to tame gcc warning
Date: Fri, 6 Nov 2020 09:24:09 +0000 [thread overview]
Message-ID: <fcfd34532a8349cabad2cbd561fa1a60@AcuMS.aculab.com> (raw)
In-Reply-To: <71dc38c1646980840fb83d82fc588501af72e05f.camel@perches.com>
From: Joe Perches
> Sent: 06 November 2020 06:36
>
> On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
> > There are some macros unused, they causes much gcc warnings. Let's
> > remove them to tame gcc.
>
> I believe these to be essentially poor warnings.
Indeed.
One 'solution' is to move the #defines into an included .h file.
> Aren't these warnings generated only when adding W=2 to the make
> command line?
>
> Perhaps it's better to move the warning to level 3
I'd move then to level 9999999999.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-11-06 9:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 5:37 [PATCH] net/dsa: remove unused macros to tame gcc warning Alex Shi
2020-11-06 6:36 ` Joe Perches
2020-11-06 8:28 ` Alex Shi
2020-11-06 8:52 ` Joe Perches
2020-11-06 8:57 ` Alex Shi
2020-11-06 9:24 ` David Laight [this message]
2020-11-06 14:18 ` Andrew Lunn
2020-11-06 16:39 ` Florian Fainelli
2020-11-07 12:54 ` Alex Shi
2020-11-07 17:39 ` Joe Perches
2020-11-07 22:33 ` Andrew Lunn
2020-11-08 12:39 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcfd34532a8349cabad2cbd561fa1a60@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=alex.shi@linux.alibaba.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox