From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759861AbdKPPXp (ORCPT ); Thu, 16 Nov 2017 10:23:45 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38282 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759056AbdKPPXf (ORCPT ); Thu, 16 Nov 2017 10:23:35 -0500 Subject: Re: [RFC 00/19] KVM: s390/crypto/vfio: guest dedicated crypto adapters To: Cornelia Huck Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, qemu-s390x@nongnu.org, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com References: <1507916344-3896-1-git-send-email-akrowiak@linux.vnet.ibm.com> <5baf5f90-6cac-3c09-7b66-1bc8b30b8093@linux.vnet.ibm.com> <20171114145722.4ab850a5.cohuck@redhat.com> From: Tony Krowiak Date: Thu, 16 Nov 2017 10:23:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20171114145722.4ab850a5.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17111615-0016-0000-0000-000007D13FBC X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008074; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000240; SDB=6.00946743; UDB=6.00477921; IPR=6.00727035; BA=6.00005694; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018046; XFM=3.00000015; UTC=2017-11-16 15:23:32 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17111615-0017-0000-0000-00003C46AEA1 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-16_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711160205 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/14/2017 08:57 AM, Cornelia Huck wrote: > On Tue, 31 Oct 2017 15:39:09 -0400 > Tony Krowiak wrote: > >> On 10/13/2017 01:38 PM, Tony Krowiak wrote: >> Ping >>> Tony Krowiak (19): >>> KVM: s390: SIE considerations for AP Queue virtualization >>> KVM: s390: refactor crypto initialization >>> s390/zcrypt: new AP matrix bus >>> s390/zcrypt: create an AP matrix device on the AP matrix bus >>> s390/zcrypt: base implementation of AP matrix device driver >>> s390/zcrypt: register matrix device with VFIO mediated device >>> framework >>> KVM: s390: introduce AP matrix configuration interface >>> s390/zcrypt: support for assigning adapters to matrix mdev >>> s390/zcrypt: validate adapter assignment >>> s390/zcrypt: sysfs interfaces supporting AP domain assignment >>> s390/zcrypt: validate domain assignment >>> s390/zcrypt: sysfs support for control domain assignment >>> s390/zcrypt: validate control domain assignment >>> KVM: s390: Connect the AP mediated matrix device to KVM >>> s390/zcrypt: introduce ioctl access to VFIO AP Matrix driver >>> KVM: s390: interface to configure KVM guest's AP matrix >>> KVM: s390: validate input to AP matrix config interface >>> KVM: s390: New ioctl to configure KVM guest's AP matrix >>> s390/facilities: enable AP facilities needed by guest > I think the approach is fine, and the code also looks fine for the most > part. Some comments: > > - various patches can be squashed together to give a better > understanding at a glance Which patches would you squash? > - this needs documentation (as I already said) My plan is to take the cover letter patch and incorporate that into documentation, then replace the cover letter patch with a more concise summary. > - some of the driver/device modelling feels a bit awkward (commented in > patches) -- I'm not sure that my proposal is better, but I think we > should make sure the interdependencies are modeled correctly I am responding to each patch review individually. > - some minor stuff >