From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 10/12] perf report: implement record trace decompression
Date: Mon, 18 Mar 2019 15:06:26 +0300 [thread overview]
Message-ID: <fd0e44e1-beec-7ebb-e617-72824dbd3399@linux.intel.com> (raw)
In-Reply-To: <20190318114619.GA7900@krava>
On 18.03.2019 14:46, Jiri Olsa wrote:
> On Sat, Mar 16, 2019 at 05:17:06PM +0300, Alexey Budankov wrote:
>
> SNIP
>
>> static int perf_session__deliver_event(struct perf_session *session,
>> union perf_event *event,
>> struct perf_tool *tool,
>> @@ -198,12 +259,23 @@ static void perf_session__delete_threads(struct perf_session *session)
>>
>> void perf_session__delete(struct perf_session *session)
>> {
>> + struct decomp *next, *decomp;
>> + size_t decomp_len;
>> if (session == NULL)
>> return;
>> auxtrace__free(session);
>> auxtrace_index__free(&session->auxtrace_index);
>> perf_session__destroy_kernel_maps(session);
>> perf_session__delete_threads(session);
>> + next = session->decomp;
>> + decomp_len = session->header.env.comp_mmap_len;
>> + do {
>> + decomp = next;
>> + if (decomp == NULL)
>> + break;
>> + next = decomp->next;
>> + munmap(decomp, decomp_len + sizeof(struct decomp));
>> + } while (1);
>
> please put this to separate function
in v10.
~Alexey
>
> thanks,
> jirka
>
next prev parent reply other threads:[~2019-03-18 12:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 8:58 [PATCH v9 00/12] perf: enable compression of record mode trace to save storage space Alexey Budankov
2019-03-16 14:09 ` [PATCH v9 01/12] feature: implement libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines Alexey Budankov
2019-03-16 14:10 ` [PATCH v9 02/12] perf record: implement --mmap-flush=<number> option Alexey Budankov
2019-03-16 14:11 ` [PATCH v9 03/12] perf session: define bytes_transferred and bytes_compressed metrics Alexey Budankov
2019-03-16 14:12 ` [PATCH v9 04/12] perf record: implement COMPRESSED event record and its attributes Alexey Budankov
2019-03-16 14:13 ` [PATCH v9 05/12] perf mmap: implement dedicated memory buffer for data compression Alexey Budankov
2019-03-16 14:13 ` [PATCH v9 06/12] perf util: introduce Zstd streaming based compression API Alexey Budankov
2019-03-16 14:14 ` [PATCH v9 07/12] perf record: implement compression for serial trace streaming Alexey Budankov
2019-03-16 14:15 ` [PATCH v9 08/12] perf record: implement compression for AIO " Alexey Budankov
2019-03-16 14:16 ` [PATCH v9 09/12] perf record: implement -z,--compression_level[=<n>] option Alexey Budankov
2019-03-16 14:17 ` [PATCH v9 10/12] perf report: implement record trace decompression Alexey Budankov
2019-03-18 11:46 ` Jiri Olsa
2019-03-18 12:06 ` Alexey Budankov [this message]
2019-03-16 14:17 ` [PATCH v9 11/12] perf inject: enable COMPRESSED records decompression Alexey Budankov
2019-03-16 14:18 ` [PATCH v9 12/12] perf tests: implement Zstd comp/decomp integration test Alexey Budankov
2019-03-18 11:46 ` Jiri Olsa
2019-03-18 12:07 ` Alexey Budankov
2019-03-18 11:46 ` [PATCH v9 00/12] perf: enable compression of record mode trace to save storage space Jiri Olsa
2019-03-18 17:57 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd0e44e1-beec-7ebb-e617-72824dbd3399@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox