From: Christian Schrefl <chrisi.schrefl@gmail.com>
To: "Benno Lossin" <benno.lossin@proton.me>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Fiona Behrens" <me@kloenk.dev>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rust: pin-init: fix typos
Date: Sat, 26 Apr 2025 12:48:26 +0200 [thread overview]
Message-ID: <fd150149-e7d3-4b09-b6e2-a633edda5791@gmail.com> (raw)
In-Reply-To: <20250426083901.13289-1-benno.lossin@proton.me>
On 26.04.25 10:39 AM, Benno Lossin wrote:
> Correct two typos in the `Wrapper::pin_init` documentation.
>
> Link: https://github.com/Rust-for-Linux/pin-init/pull/48/commits/fd0bf5e244b685188dc642fc4a0bd3f042468fdb
> Signed-off-by: Benno Lossin <benno.lossin@proton.me>
> ---
> Second round of pin-init syncs for v6.16. Depends on
>
> https://lore.kernel.org/all/20250421221728.528089-1-benno.lossin@proton.me
> ---
> rust/pin-init/src/lib.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/pin-init/src/lib.rs b/rust/pin-init/src/lib.rs
> index 05a0cd6ad8f4..b5a295effd9c 100644
> --- a/rust/pin-init/src/lib.rs
> +++ b/rust/pin-init/src/lib.rs
> @@ -1580,7 +1580,7 @@ unsafe impl<$first: Zeroable, $($t: Zeroable),*> Zeroable for ($first, $($t),*)
> /// });
> /// ```
> pub trait Wrapper<T> {
> - /// Create an pin-initializer for a [`Self`] containing `T` form the `value_init` initializer.
> + /// Creates an pin-initializer for a [`Self`] containing `T` from the `value_init` initializer.
> fn pin_init<E>(value_init: impl PinInit<T, E>) -> impl PinInit<Self, E>;
> }
>
>
> base-commit: 39051adb070432b283e6c11b2b24937281b9f97f
Reviewed-by: Christian Schrefl <chrisi.schrefl@gmail.com>
next prev parent reply other threads:[~2025-04-26 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-26 8:39 [PATCH 1/2] rust: pin-init: fix typos Benno Lossin
2025-04-26 8:39 ` [PATCH 2/2] rust: pin-init: improve documentation for `Zeroable` derive macros Benno Lossin
2025-04-26 11:36 ` Christian Schrefl
2025-04-26 10:48 ` Christian Schrefl [this message]
2025-05-01 16:38 ` [PATCH 1/2] rust: pin-init: fix typos Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd150149-e7d3-4b09-b6e2-a633edda5791@gmail.com \
--to=chrisi.schrefl@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=me@kloenk.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox