From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jason Gunthorpe" <jgg@ziepe.ca>, "Will Deacon" <will@kernel.org>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Baoquan He" <bhe@redhat.com>,
"Kefeng Wang" <wangkefeng.wang@huawei.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] arm64/io: add constant-argument check
Date: Tue, 04 Jun 2024 22:44:06 +0200 [thread overview]
Message-ID: <fd2b865e-ddde-40ff-95a9-bc43bd48b549@app.fastmail.com> (raw)
In-Reply-To: <20240604201251.GA791043@ziepe.ca>
On Tue, Jun 4, 2024, at 22:12, Jason Gunthorpe wrote:
> On Tue, Jun 04, 2024 at 04:55:37PM +0100, Will Deacon wrote:
>> On Tue, May 28, 2024 at 05:37:11PM +0200, Arnd Bergmann wrote:
>>
>> I think this is superseded by Mark's diff in reply to v1, right?
>>
>> https://lore.kernel.org/r/ZlcODqVXTDh6n0h-@J2N7QTR9R3
>>
>> If so, Mark, please can you post that as a proper patch so that we can
>> get this fixed?
>
> I wouldn't say superseded, but I agree with Mark that we should have
> the __always_inline added to the __iowrite64_copy() and
> __const_memcpy_toio_aligned64() in addition to the stuff here.
>
> When I originally wrote this I copied the fairly common pattern of
> having the builtin_constant_p test inside a macro, but I see now it is
> quite common to put that into an inline. Putting it in the inline is
> definately much better, so I like Arnd's patch.
>
> Arnd can you just make that addition and repost this?
>
Yes, sorry for failing to follow up earlier. I'm doing a little
more build testing now, will send soon.
Arnd
prev parent reply other threads:[~2024-06-04 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 15:37 [PATCH] [v2] arm64/io: add constant-argument check Arnd Bergmann
2024-06-04 15:55 ` Will Deacon
2024-06-04 20:12 ` Jason Gunthorpe
2024-06-04 20:44 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd2b865e-ddde-40ff-95a9-bc43bd48b549@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhe@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=jgg@ziepe.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox