From: Cryolitia PukNgae <cryolitia@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-doc@vger.kernel.org,
"Celeste Liu" <CoelacanthusHex@gmail.com>,
"Marcin Strągowski" <marcin@stragowski.com>
Subject: Re: [PATCH v2 1/2] hwmon: add GPD devices sensor driver
Date: Wed, 17 Jul 2024 15:01:02 +0800 [thread overview]
Message-ID: <fd9423c0-8c2b-4aef-9d76-cb7def3e2344@gmail.com> (raw)
In-Reply-To: <7e4e45e1-9a77-4780-a5bd-ac44cd7c6cdd@kernel.org>
On 2024/7/17 03:28, Krzysztof Kozlowski wrote:
> Why would you add here untested models?
The manufacturer GPD sent me these quirks and reg addresses, and they
used them to write their Windows user space driver. They are unlikely to
have problems. It was fully tested by several people on WIn Max 2 2023
and Win 4, and there's only little address difference with other model.
> static, so how do you support more than one device?
The device will have and only have one EC controller, I use
platform_device just for easier alloc and release resources.
Sincerely thank you for your guidance, v3 has been sent:
https://lore.kernel.org/r/20240717-gpd_fan-v3-0-8d7efb1263b7@gmail.com
next prev parent reply other threads:[~2024-07-17 7:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 16:58 [PATCH v2 0/2] hwmon: add GPD devices sensor driver Cryolitia PukNgae via B4 Relay
2024-07-16 16:58 ` [PATCH v2 1/2] " Cryolitia PukNgae via B4 Relay
2024-07-16 18:04 ` Guenter Roeck
2024-07-17 7:03 ` Cryolitia PukNgae
2024-07-16 19:28 ` Krzysztof Kozlowski
2024-07-17 7:01 ` Cryolitia PukNgae [this message]
2024-07-17 7:04 ` Krzysztof Kozlowski
2024-07-16 16:58 ` [PATCH v2 2/2] hwmon: document: add gpd-fan Cryolitia PukNgae via B4 Relay
2024-07-16 21:20 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd9423c0-8c2b-4aef-9d76-cb7def3e2344@gmail.com \
--to=cryolitia@gmail.com \
--cc=CoelacanthusHex@gmail.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcin@stragowski.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox