From: linmiaohe <linmiaohe@huawei.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"sebott@linux.ibm.com" <sebott@linux.ibm.com>,
"lukas@wunner.de" <lukas@wunner.de>,
"gustavo@embeddedor.com" <gustavo@embeddedor.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mingfangsen <mingfangsen@huawei.com>
Subject: Re: [PATCH] net: pci: Fix hotplug event timeout with shpchp
Date: Wed, 3 Jul 2019 02:07:51 +0000 [thread overview]
Message-ID: <fdbaef22bd774ee49fc58fe13a76bf91@huawei.com> (raw)
On Tue, Jul 02, 2019 at 01:35:19PM +0000, Miaohe Lin wrote:
> > Hotplug a network card would take more than 5 seconds in qemu + shpchp
> > scene. It’s because 5 seconds delayed_work in func
>
> I'm dropping this because of the required delay pointed out by Lukas.
>
> If you think we still need to do something here, please clarify the situation. Are you hot-adding? Hot-swapping? Since you mention a protocol timeout, I suspect the latter, e.g., maybe you had an existing device with connections already open, and you want to replace it with a new device
> We do have to preserve the existing user experience, e.g., delays to allow operators to recover from mistaken latch opens or button presses. But if we knew more about what you're trying to do, maybe we could figure out another approach.
Thanks for your reply. As is spec required, we would try to work around it.
Many thanks.
Have a good day.
Best wishes.
next reply other threads:[~2019-07-03 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 2:07 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-07-02 13:35 [PATCH] net: pci: Fix hotplug event timeout with shpchp Miaohe Lin
2019-07-02 17:50 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdbaef22bd774ee49fc58fe13a76bf91@huawei.com \
--to=linmiaohe@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mingfangsen@huawei.com \
--cc=sebott@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox