From: Gerhard Engleder <gerhard@engleder-embedded.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
Gerhard Engleder <eg@keba.com>
Subject: Re: [PATCH 1/6] misc: keba: Add SPI controller device
Date: Thu, 10 Oct 2024 21:53:58 +0200 [thread overview]
Message-ID: <fdd45a82-bf05-4e03-bac2-cb670bbf5200@engleder-embedded.com> (raw)
In-Reply-To: <2024101026-scoured-conductor-c92e@gregkh>
On 10.10.24 09:12, Greg KH wrote:
> On Wed, Oct 09, 2024 at 10:29:44PM +0200, Gerhard Engleder wrote:
>> static void cp500_register_auxiliary_devs(struct cp500 *cp500)
>> {
>> struct device *dev = &cp500->pci_dev->dev;
>>
>> if (cp500_register_i2c(cp500))
>> - dev_warn(dev, "Failed to register i2c!\n");
>> + dev_warn(dev, "Failed to register I2C!\n");
>
> Nit, this doesn't have anything to do with the original commit message,
> please be more careful when splitting patches up into a series.
Yes, I also did some variable renaming, which should be moved to a
separate commit. I will be more strict in the future.
Thanks!
Gerhard
next prev parent reply other threads:[~2024-10-10 20:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 20:29 [PATCH 0/6] misc: keba: Add support for additional devices Gerhard Engleder
2024-10-09 20:29 ` [PATCH 1/6] misc: keba: Add SPI controller device Gerhard Engleder
2024-10-10 7:12 ` Greg KH
2024-10-10 19:53 ` Gerhard Engleder [this message]
2024-10-13 1:03 ` kernel test robot
2024-10-09 20:29 ` [PATCH 2/6] misc: keba: Add LAN9252 driver Gerhard Engleder
2024-10-11 8:28 ` kernel test robot
2024-10-09 20:29 ` [PATCH 3/6] misc: keba: Support EEPROM sections as separate devices Gerhard Engleder
2024-10-13 8:52 ` kernel test robot
2024-10-09 20:29 ` [PATCH 4/6] misc: keba: Add fan device Gerhard Engleder
2024-10-09 20:29 ` [PATCH 5/6] misc: keba: Add battery device Gerhard Engleder
2024-10-09 20:29 ` [PATCH 6/6] misc: keba: Add UART devices Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdd45a82-bf05-4e03-bac2-cb670bbf5200@engleder-embedded.com \
--to=gerhard@engleder-embedded.com \
--cc=arnd@arndb.de \
--cc=eg@keba.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox