From: Mark Bloch <mbloch@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Tariq Toukan <tariqt@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Gal Pressman <gal@nvidia.com>,
linux-rdma@vger.kernel.org, Alexei Lazar <alazar@nvidia.com>
Subject: Re: [PATCH net V2 10/11] net/mlx5e: Update and set Xon/Xoff upon port speed set
Date: Thu, 11 Sep 2025 17:25:22 +0300 [thread overview]
Message-ID: <fdd4a537-8fa3-42ae-bfab-80c0dc32a7c2@nvidia.com> (raw)
In-Reply-To: <20250911064732.2234b9fb@kernel.org>
On 11/09/2025 16:47, Jakub Kicinski wrote:
> On Wed, 10 Sep 2025 17:00:11 -0700 Jakub Kicinski wrote:
>> On Mon, 25 Aug 2025 17:34:33 +0300 Mark Bloch wrote:
>>> Xon/Xoff sizes are derived from calculations that include
>>> the port speed.
>>> These settings need to be updated and applied whenever the
>>> port speed is changed.
>>> The port speed is typically set after the physical link goes down
>>> and is negotiated as part of the link-up process between the two
>>> connected interfaces.
>>> Xon/Xoff parameters being updated at the point where the new
>>> negotiated speed is established.
>>
>> Hi, this is breaking dual host CX7 w/ 28.45.1300 (but I think most
>> older FW versions, too). Looks like the host is not receiving any
>> mcast (ping within a subnet doesn't work because the host receives
>> no ndisc), and most traffic slows down to a trickle.
>> Lost of rx_prio0_buf_discard increments.
>>
>> Please TAL ASAP, this change went to LTS last week.
>
> Any news on this? I heard that it also breaks DCB/QoS configuration
> on 6.12.45 LTS.
Hi Jakub,
We are looking into this, once we have anything I'll update.
Just to make sure, reverting this is one commit solves the
issue you are seeing?
Mark
next prev parent reply other threads:[~2025-09-11 14:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 14:34 [PATCH net V2 00/11] mlx5 misc fixes 2025-08-25 Mark Bloch
2025-08-25 14:34 ` [PATCH net V2 01/11] net/mlx5: HWS, Fix memory leak in hws_pool_buddy_init error path Mark Bloch
2025-08-25 14:34 ` [PATCH net V2 02/11] net/mlx5: HWS, Fix memory leak in hws_action_get_shared_stc_nic error flow Mark Bloch
2025-08-25 14:34 ` [PATCH net V2 03/11] net/mlx5: HWS, Fix uninitialized variables in mlx5hws_pat_calc_nop " Mark Bloch
2025-08-25 14:34 ` [PATCH net V2 04/11] net/mlx5: HWS, Fix pattern destruction in mlx5hws_pat_get_pattern error path Mark Bloch
2025-08-25 14:34 ` [PATCH net V2 05/11] net/mlx5: Reload auxiliary drivers on fw_activate Mark Bloch
2025-08-25 14:34 ` [PATCH net V2 06/11] net/mlx5: Fix lockdep assertion on sync reset unload event Mark Bloch
2025-08-25 14:34 ` [PATCH net V2 07/11] net/mlx5: Nack sync reset when SFs are present Mark Bloch
2025-08-25 14:34 ` [PATCH net V2 08/11] net/mlx5: Prevent flow steering mode changes in switchdev mode Mark Bloch
2025-08-25 14:34 ` [PATCH net V2 09/11] net/mlx5e: Update and set Xon/Xoff upon MTU set Mark Bloch
2025-08-25 14:34 ` [PATCH net V2 10/11] net/mlx5e: Update and set Xon/Xoff upon port speed set Mark Bloch
2025-09-11 0:00 ` Jakub Kicinski
2025-09-11 13:47 ` Jakub Kicinski
2025-09-11 14:25 ` Mark Bloch [this message]
2025-09-11 14:36 ` Jakub Kicinski
2025-09-15 7:38 ` Tariq Toukan
2025-09-17 10:39 ` Tariq Toukan
2025-09-17 13:00 ` Daniel Zahka
2025-09-17 13:38 ` Tariq Toukan
2025-08-25 14:34 ` [PATCH net V2 11/11] net/mlx5e: Set local Xoff after FW update Mark Bloch
2025-08-27 1:10 ` [PATCH net V2 00/11] mlx5 misc fixes 2025-08-25 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdd4a537-8fa3-42ae-bfab-80c0dc32a7c2@nvidia.com \
--to=mbloch@nvidia.com \
--cc=alazar@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox