From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E20D53203AA for ; Thu, 6 Nov 2025 14:50:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762440649; cv=none; b=B6+Co/lLRmyrEvPBcifpgC68dhqCM3XIgmT9UDBUeiJSKTiLdPO6MyNoPlDsx1uiuScwv5flwfB4Dun6FXmGIEScSVlMj8I0S8/2bSMz6NaJVUBGZw8p6tVThThxhM3K0LdijS3NPrD0TV/J5M63UN0t7zAQUH5+JNFtfI8eN3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762440649; c=relaxed/simple; bh=LWM0l4vzzbacqdnVzpCnRRUWEOcQxOAdXEAdjEcgw4s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KtBTILIbqLwxVylGpeuoT5vwxddspv+IuZ9bTXPuWyZeTWWvYWH9WBu7mLYBJEjQ60xfN+gOOCYV9YfkHD/4tI901/qE7LX6667RQdZrIq0boOJUCgFSX92hAZJd8HTlIqd5Bds1kklFPV8AKcm1Xu3BofXqy+dGUWN8liQeWKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aiWKQcAF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AinBshkz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aiWKQcAF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AinBshkz" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A66rB8u3361967 for ; Thu, 6 Nov 2025 14:50:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +c/QOz5FWP7I3LmCV+SwCpj23lo4cqX+0KR+4hGKgwo=; b=aiWKQcAFWqcZzvGc YiTfnQU70O1Cm/+AL4xg3JhPMxgPcSzp0HFbt6WJ/luulrbH34FYMgJDW1pPCStD AtDY6gnb1jjAKwE6dE92jvyiCCqyxl5YnGBrhVCDf4nku7sogirG9efGnsBAAcJN 4OOSEb1kpJerjBaOGBjhQdaUtdsh2Lt//LokUKGQqFQEPXlspYSueLJiIkyT2waK pfgwEN8HtDdtlFuRJxnGfls1QMgSg5jtt1rfkBglCT4kly38SgbKi1EFIfcRlaZV uXRU4aiXYpTd3goEZpZDho6lyP8b2GY8HH1AcoV36l2fsdt4lq83bSFh02MIjFI2 tzvvhw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a8pt59adb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 06 Nov 2025 14:50:47 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3418c17d21dso1150988a91.2 for ; Thu, 06 Nov 2025 06:50:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762440646; x=1763045446; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+c/QOz5FWP7I3LmCV+SwCpj23lo4cqX+0KR+4hGKgwo=; b=AinBshkziaDfbl7t6QLG0GowA5fREtn+pIr6VSJJAfCcXr/bUFM10l3M0s0JYl1XsO 7QS1Z0zSpKYOjvWdEuLH1XJFxVMPJ7V5agSoAsL2i9qufdeJOyswuPUWMVKaXdOYzvK7 e8qRKbzLzgXE2+XVrST7TsG+hhvtdXB1YeruIubujm/eWg5a4+pwYcb1bS5QJl4mVUBU 6Hl25fmfRNDQSzPIoktzqasNfkDxG5Kc7juSHQpuffK0Z0IRL0tIfeFPuIstqQi24oo5 sOzpYWf7jSkzu8GNumwS0cQ969Msw0p2Mwxv9ChLytr2oFqeMMLHLE3CWZTN/v9UaXMW rDvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762440646; x=1763045446; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+c/QOz5FWP7I3LmCV+SwCpj23lo4cqX+0KR+4hGKgwo=; b=tZ54hZLJxlWbfXNc0xeQcg5vRo5UQj/qYJKlrNNRUmKR+LIF2UFv8WAmXLMcghdviV OKPn7zJ1MqS9GxygAubgeq8TUCUbvOzx+GYw0Z+R1VxqFPVyF7YMPwgJXaisD4wMvncm B/JW9A6Vq2ulNgE0+oXCKnpbptBvmq8M/yQLy6YiVhZWZUCuBlEwMINI7ZPQG9VEVsgR 3bfjpTO1/opTByBbHM3nEnKxjVfwcJVAiibRc9VhdmhnVKIRYspXoAVd+tCaAGDCa/+f seRfqCZnBuJ1iQ5AJIopfV47FUGT0/zOQqki7T3j/KBKP0ljWeK6LwnqBhTPCyUC1c0M LnoQ== X-Forwarded-Encrypted: i=1; AJvYcCW0/jyVLPLqEwUsuQvbQT9AEZpVs0srhU2uVWSMI1eWs9+S1IidaUvfRhIYKEcrpSFOIJHkQNvSOA3QNr0=@vger.kernel.org X-Gm-Message-State: AOJu0YyvtLDYcDMM1DutG5PkaI5riLLUh8+lHrAPmrckAJSNTYuD1KLn BweLQvo1tsg+iAHnDWkc2gc7Qu/fnvVW3vhheJbpgd4dBE72XQFhQyIRg89kW1eF//KqQ0ETRbF m8N+Cdmq1bDIKrsr+KOwFgGp08dPHzpdDJGOOhXnFuYt038ANWOBs+Wo0PGwPE9Spjvg= X-Gm-Gg: ASbGncu20SV4KHGv2x1KrPB/eLoe6Tcjg6Panajn0GtU8SlXp2e+/fWBgrechlj+QwR T1vZqyk/UyZKzD4qOpGjFnj1LlS/9j1bJM48pZrx5FjYteJI9vh83fmGEiHyWhYFjcsk9jluDc1 2nlwbMA0VgN0VbQr1LLqVW7X3WS6uWaDqpV+AZbLh/t8JTaSFp2ZQBGG7kMEx2T81sG1wtcmJrO m1W8IARueLDX4bL9qgdx1710tro02qm+ni7kG0RnmyJH51Rdcu0MdyjqQFsdoSzGzOFVUv2pVTl wUxP1H0k84m6v4LpoDbh72K25lSpwC+qq93xhjJWcU1Dv8CueSr5pD0btupiVOxRcW2diOjSh3t Xy/Fi2UypzJNmjGEkOkEiHEk4su5hnV6LIw== X-Received: by 2002:a17:903:240e:b0:295:3a79:e7e5 with SMTP id d9443c01a7336-2962ad88638mr95158365ad.34.1762440646349; Thu, 06 Nov 2025 06:50:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IEDRjrSPgAtrWEFqUDfncKSqQ+S6NIN3iMJTRreo40l/2rWNYrrLBKk8fycn3wYrt9sMYdptw== X-Received: by 2002:a17:903:240e:b0:295:3a79:e7e5 with SMTP id d9443c01a7336-2962ad88638mr95157765ad.34.1762440645836; Thu, 06 Nov 2025 06:50:45 -0800 (PST) Received: from [192.168.0.171] ([49.205.253.130]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2965096b90asm31242295ad.23.2025.11.06.06.50.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Nov 2025 06:50:45 -0800 (PST) Message-ID: Date: Thu, 6 Nov 2025 20:20:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding To: Krzysztof Kozlowski , Konrad Dybcio , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy References: <20251017-knp_video-v2-0-f568ce1a4be3@oss.qualcomm.com> <20251017-knp_video-v2-1-f568ce1a4be3@oss.qualcomm.com> <034bf6f4-0a49-4973-8536-28526b3409d1@oss.qualcomm.com> <9c920cdf-1985-4656-bee2-8bfacc15bfa9@oss.qualcomm.com> <24719933-d81f-41cb-aabc-e28f018b156c@kernel.org> Content-Language: en-US From: Vikash Garodia In-Reply-To: <24719933-d81f-41cb-aabc-e28f018b156c@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: xHdVmP7r_9fUmdSmapfPGjVicQ3Veoc8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA2MDExNyBTYWx0ZWRfXzpLXH/5QtoKl jkht024GACAORbRZ+YTyUJPsiJIurPLKy1C6rXhFFCjFDs8KpNcTabWJ2uWP5sFDKGtu57fca7x a38XXAQP3yLwkI/BdleH3Qaq3stfEpR47DK7wDqUFEMIaotOfjB+sGNta/9GfmtGtiX98NuIjFz 8f5lnejFvpgL99hO19IkXW66LA1FFeR9IxXupFMbBYJmU/UNooXU2/YqF5IX8Ysp2isrtTGItLy OAcI4oAGytG3n+wVwpNaVw5M8QwNWLcOSULxJ+PsMHeojpNLlrUPR2SPPRs83c8L0VessaSYlj2 vN7h/q4dKxkiErtbWxPndiD2cFuC4q2IcRjfOWm+PsRcnblUzKEoVtL864u31OjPPvpqKkujTv2 ZR7eZC3DWFdLJ+LYvUD8+AqK7+6Hkw== X-Authority-Analysis: v=2.4 cv=XNI9iAhE c=1 sm=1 tr=0 ts=690cb5c7 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=qKS+5dAnvCMTy05vH4hvkg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=9_Y8sxrH3V15ADIk1vQA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: xHdVmP7r_9fUmdSmapfPGjVicQ3Veoc8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-06_03,2025-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511060117 On 10/22/2025 9:58 PM, Krzysztof Kozlowski wrote: > On 22/10/2025 17:36, Konrad Dybcio wrote: >>> >>> [ 1.361157] pc : qcom_smmu_write_s2cr+0x64/0xa4 >>> [ 1.361165] lr : arm_smmu_write_s2cr+0x2c/0xbc >>> [ 1.361168] sp : ffff80008005b8f0 >>> [ 1.361169] x29: ffff80008005b8f0 x28: 0000000000000000 x27: ffffc7f252f45320 >>> .... >>> [ 1.361195] x2 : ffff800081200c48 x1 : 0000000000000048 x0 : ffff800081200000 >>> [ 1.361198] Call trace: >>> [ 1.361199] qcom_smmu_write_s2cr+0x64/0xa4 (P) >>> [ 1.361203] arm_smmu_master_install_s2crs+0x7c/0xac >>> [ 1.361207] arm_smmu_attach_dev+0xb0/0x1d4 >>> >>> Could you please suggest on listing the iommu items ? I did not find the >>> relevant references in other bindings where flexible iommus is being listed. >> >> Krzysztof would probably like to see what I believe someone else somewhere >> sometime suggested in the iommus discussions (sorry it's not possible to >> keep track of it all), where the DT can list every possible required iommu >> sid, but the driver ensures only the ones that are necessary are utilized. >> >> This will require big changes to the iommu framework though, I'm afraid >> >>>> I already asked this. >>>> >>>>> + >>>>> + memory-region: >>>>> + minItems: 1 >>>>> + maxItems: 2 >>>> >>>> Same comment. I already asked this about iommus. >>> >>> Same here, there aren't any bindings which lists for flexible memory-region. >>> Please suggest if there are any such references. >> >> Similarly, we can define the additional memory region that's necessary >> for $reasons and leave it unused in the driver (actually I don't know >> why there may be two, but let's assume it's a QTEE/noQTEE detail), because >> for the hw to operate, it must be set up by some entity in the system >> either way (i.e. the memory is reserved even if it's not done by Linux) > > > Another point is pretty obvious: if one claims that > iommus/memory-regions list is flexible - some elements are optional - > then clearly there is a distinction which elements are mandatory and > which are optional. So there is difference between elements of the > array. If there is a difference, they all must be explicitly listed, > like every other list (clocks, resets etc) property. Writing bindings > doc also defines this rule. > I would like to describe the video bindings covering all the interfaces, including the secure stream ids. For this to do, i would have to wait for [1] to conclude. Will put up a new revision on this series, to exclude the binding patch and the one which enables kaanapali. That way we can have the driver prepared for vpu4, while kaanapali binding and patch to enable it in driver can be raised separately later once [1] is concluded. [1] https://lore.kernel.org/all/cover.1762235099.git.charan.kalla@oss.qualcomm.com/ Regards, Vikash