From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E2B7E810A8 for ; Wed, 27 Sep 2023 09:05:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230376AbjI0JFO (ORCPT ); Wed, 27 Sep 2023 05:05:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230320AbjI0JFJ (ORCPT ); Wed, 27 Sep 2023 05:05:09 -0400 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F3A8BF; Wed, 27 Sep 2023 02:05:07 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R951e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0VszpuXE_1695805503; Received: from 30.97.48.70(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VszpuXE_1695805503) by smtp.aliyun-inc.com; Wed, 27 Sep 2023 17:05:04 +0800 Message-ID: Date: Wed, 27 Sep 2023 17:05:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH V2 2/2] gpio: pmic-eic-sprd: Add can_sleep flag for PMIC EIC chip To: Wenhua Lin , Linus Walleij , Andy Shevchenko , Bartosz Golaszewski Cc: Orson Zhai , Chunyan Zhang , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, wenhua lin , Xiongpeng Wu References: <20230921122527.15261-1-Wenhua.Lin@unisoc.com> <20230921122527.15261-3-Wenhua.Lin@unisoc.com> From: Baolin Wang In-Reply-To: <20230921122527.15261-3-Wenhua.Lin@unisoc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/21/2023 8:25 PM, Wenhua Lin wrote: > The drivers uses a mutex and I2C bus access in its PMIC EIC chip > get implementation. This means these functions can sleep and the PMIC EIC > chip should set the can_sleep property to true. > > This will ensure that a warning is printed when trying to get the > value from a context that potentially can't sleep. LGTM. Reviewed-by: Baolin Wang > Signed-off-by: Wenhua Lin > --- > drivers/gpio/gpio-pmic-eic-sprd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c > index 442968bb2490..f04a40288638 100644 > --- a/drivers/gpio/gpio-pmic-eic-sprd.c > +++ b/drivers/gpio/gpio-pmic-eic-sprd.c > @@ -353,6 +353,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev) > pmic_eic->chip.set_config = sprd_pmic_eic_set_config; > pmic_eic->chip.set = sprd_pmic_eic_set; > pmic_eic->chip.get = sprd_pmic_eic_get; > + pmic_eic->chip.can_sleep = true; > > irq = &pmic_eic->chip.irq; > gpio_irq_chip_set_chip(irq, &pmic_eic_irq_chip);