From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C70E339022D for ; Fri, 3 Apr 2026 09:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775209411; cv=none; b=sa3nm9khzoaaheb2SLR3dt4dG++N9CkSGGXOJnepCEME2oOzd8f6yyT2gMmsb4wFg3hhApu0mgW0wAjrD3qhmj5Lp+fyise6d9W4utEsyvckJNx37c3iEFfvRPBzcp1c+MhBc1hPZwcjx1J7sEqedsHjjVd7zAjYPi8caI6EFQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775209411; c=relaxed/simple; bh=4mcXj8n21nn8IOpehKLpsbJ3K8jdzjXslOfmGaZD28U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s6gOF375arZ4ZC6SnSxkm/iyVol6XUSij3HWjDXCG+sum/c/2FFRw5CIZn4zZFFzSks/uOPk5UpmQAWIpxXzaWejXSjZZ2BFhwsPoa1ZT4yIlE1Xn4oQuqgKgZ5kPr/Wz8LjnHdpU6sj7QF6wg2daDXIzLmFtNTfddm9X+61GoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lvmx2sIt; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lvmx2sIt" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-486fb14227cso23482035e9.3 for ; Fri, 03 Apr 2026 02:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775209406; x=1775814206; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5InlHETi+SIWgmcBrnKanh/RI7eCvH1urjB/VkUdx5Y=; b=lvmx2sItbCzf5zq/d8iaEK0u9Swmr98ak1Ydzhz/PQ9DuTJIh78H7O7RnKWS0wLEMy YvwaGO+5eJxXKElKCEGCgOl9udEzryi2iEgnIyYzF8Zr956hKc7Dk0wNcVjMsSfc60Iy xfwp/TGA3YTidaviVmGNItSJGhzGUGmuq0jkYpwSkpmdxplU+N/Tzys7m2700E3LYm2g cwMuV97gvrReUJkk36PzMrh6wixcqBF68mlkbZuCyLxK0f9kq6a3PeNwvBvwAsqie1uC +ivyPD1f4uYyqNdC6pnr+kytbv9sLsqouiUOX7Gk0Hnn4MmQ7lSV76jt5uzNYODNVoyr ROtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775209406; x=1775814206; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5InlHETi+SIWgmcBrnKanh/RI7eCvH1urjB/VkUdx5Y=; b=OkPVX/RcoUSX+KAflK+2eTMcrQr5VhRVF7Jk2aQrNNpr8CV9p9wnvYnWIeGommntSr ZoWHFu6ry4/RpDRDniT3T6wCp827+8X/x7lIppBgKhH6VC+hQjsAtd9taZK4eHJNUZcN a0+EplIvK3Adny0um7Rb1VkyFZGsqxOlKMPEwWl7eATJu/uNg13b+cIXUqHOR0fIVmOa VyJ4U1c4q418s15DOhPTxc/LQgihjGWTdWwM4RSbWnYgTDRlfErZkbcCtwHxHCTD1SKs Z8l/1TEye5rC9V3tOtdrxqRhLqFBqLmb69jFgwYWt283UVQ5FsRKmz0qEwN/rTpVu51b udmg== X-Forwarded-Encrypted: i=1; AJvYcCXChzNqbb0axIzCGrXnXK4mU43yBq3/EqbtkVtq7Nqpz4qDwGjNnuebE0TJmT9ocO7VkfHlpApJuo5Ae+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxXIv5sFk/2RxtoU3bL39wjUgFaJ0jZcZeB7dYiAZ8CV2sOjip1 MnUTBP6BosE0VcQLYFOU9ljjB940V9/TEjiURuQhZbLGYd4T13r05qrE X-Gm-Gg: ATEYQzy94d58II49dYe/3htPKcnhZ/hx8iklj6VgxTd0U/rns1WGT7UV20OPtbYqBNE ott96w0dQDKK0IFVQMhLvkHKFt6MdL9lun+4bosKZkzZ2QOonHCmqOArsOKshqiYi5lJHzkzHM3 ICdWa4HbPhVlt/LqlzcK1lL8XkDYwExAmTaEnDPAswjBMEuNGL0Me8KtZ9fpXTBVku/ov2y3RZA jS5NxIB2PeczWbjwjWp1ZpcUOYWOOz7CAgWYyX70Q16FdXIWlhLlYMUvEQgA9MWPq3Jd4xONw0m T1EiiL9YwSsnV+k+bA4QAirQn1f0ugYv4Xcsiy/M+NbLrZFBT7tk+nfl9UTMrQ7002WNTBNlQ1S 7KG1PLKb5Q7yh7j5+clQwwh3FkbM08waWwwNmsGv7nEx2SCLDvwxqX2csHmJvcBrPBdSd7Xp2lg PDuS6b7yQgVHFJL9N09coU/c4ec5viRiFG9zHVe6BPwn+iUdI2I+NyIbY5grAXi18p49bbcILMu hxZDdCZ2Q== X-Received: by 2002:a05:600c:4753:b0:486:fcc7:d6a with SMTP id 5b1f17b1804b1-4889976eb60mr34158545e9.13.1775209406305; Fri, 03 Apr 2026 02:43:26 -0700 (PDT) Received: from [10.1.4.108] (cust-east-par-46-193-119-166.cust.wifirst.net. [46.193.119.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48897b8176fsm27664325e9.0.2026.04.03.02.43.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2026 02:43:26 -0700 (PDT) Message-ID: Date: Fri, 3 Apr 2026 11:43:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata To: Andrew Lunn Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Vasut , Maxime Chevallier , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Fidelio Lawson References: <20260326-ksz87xx_errata_low_loss_connections-v1-0-79a698f43626@exotec.com> <20260326-ksz87xx_errata_low_loss_connections-v1-3-79a698f43626@exotec.com> Content-Language: en-US From: Fidelio LAWSON In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/26/26 13:18, Andrew Lunn wrote: >> + mutex_lock(&dev->alu_mutex); >> + >> + ret = ksz_write8(dev, regs[REG_IND_CTRL_0], 0xA0); >> + >> + if (!ret) >> + ret = ksz_write8(dev, 0x6F, indir_reg); >> + >> + if (!ret) >> + ret = ksz_write8(dev, regs[REG_IND_BYTE], indir_val); >> + >> + mutex_unlock(&dev->alu_mutex); > > What address space are these registers in? Normally workarounds for a > PHY would be in the PHY driver. But that assumes the registers are > accessible from the PHY driver. > > Andrew Hi Andrew, These registers belong to the KSZ87xx switch address space, accessed through the switch’s indirect access mechanism. In particular, the offsets used here correspond to entries within the TABLE_LINK_MD_V indirect table of the KSZ8-family switches. In the next revision I will switch to using ksz8_ind_write8(), and I will also replace the remaining magic values with proper register macros. Best regards, Fidelio