From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B36522F3C21 for ; Wed, 3 Dec 2025 11:15:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764760507; cv=none; b=kQ3g9HLQdE3DpSYWVwULu+TpfhzjzBSe58XPNfyBC6iFBCeCDsBx/XIn0NMBFscV7nxn/DpSqDokenJAuRSDZAco4r1F6OJmjBI4Lz9j97DHmqfcXUqrOvqUeq9nSUxpTsOJzC0w3eMQkgOe4dRBVbhgJLiZiKHkB8LDHQwLwJ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764760507; c=relaxed/simple; bh=eP3tDoyJEn0q53WmiKkuekFIADve/lQCRcyXrA578eE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dymRTspUjdjpwRr8yYiYFgb5C4qoWtoDGJtDToUuJ5m7Kkpb40RAV1PUbVuDAVOlakg7uJX58jdEcp05Vl88HKYltRInkg8ySdhFkLy6qSQoiLiruUHzbD+Ol/+8T1xqroPbmW5do1opHHS2jdaOD4rBbzjRYSz7Ndnb4x8ncbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QQCgPWQv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A9uijCDO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QQCgPWQv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A9uijCDO" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B3B2gpJ385553 for ; Wed, 3 Dec 2025 11:15:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Sx0Sxi7RaZ5r/OLiymcootGTCfaloJHP1I/EOtGg0NM=; b=QQCgPWQvik8a3OvJ zv2UkH1ULms9JrlI0S6j30qdHpunRKda3yT5RSVV4gowcy0NTV81vpgpP6U+7J5D dN4wtUgJcTL71l1Y7ZEH+ZEP3ffBfBfgT8kdGSIXBSDF3R3QDoWblZGKSQ/FdJ4G MqSGs5ow2zzlIXkBCl7cj/eG/EVlzwjRpu40ljuwlHEisFF899HKWa72naXQHXD9 Qr6swy0T67BHBTOnpTmqJFdAp2nRTH31cnVoa+gb7GJ5nHbkC4p8qnpgGlq5hfF8 f7RzjZv+d9pFvQytAu02QNhuvGUcLbHhPrUgTwKeoo03e67DQxff+/vjYZtUfMHH 4MliyQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4at5db2s22-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Dec 2025 11:15:04 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ed6a906c52so13232401cf.2 for ; Wed, 03 Dec 2025 03:15:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764760504; x=1765365304; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Sx0Sxi7RaZ5r/OLiymcootGTCfaloJHP1I/EOtGg0NM=; b=A9uijCDObmxJsyhlGMFfVHNWQQV5vfqwOmBXIx8Xr+wPy7JS4maUWj9h5ulooxhOLk aebFCwI/uQ/cNhePoHGarLimKKZjfzYvaFapVi18hjNEeS/sRmX+zYUkuBuce/IpS63d rm5gKrb3uPu/sbw/HCFCXBwZtHA6qwYyrOz1v7eMxNE/Nehxb/SMMOoZuGUpQFGSwQzx uzDuTFiKIL4v4G2Qy8PnYMovKMlVQD2uFxcY8yYDOjAP1PyeAUJlnmD7EH3MT3xxze2D sszJJ0prQvLSXzfKIzlwohSWX3UUsGnZz9WdJX0C5cdv3EK2xxtXdZu1sP8VLI6NbKU+ i/MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764760504; x=1765365304; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Sx0Sxi7RaZ5r/OLiymcootGTCfaloJHP1I/EOtGg0NM=; b=X+OQ5avia48wZErBxiOBBh6fnm8JWGA5WvFfSlx6a6HYG3Jui6ieD/ESIGoJgW1HhY DZLU2WQRDRFgJitXgNyEu/KV2c3WYrakAMaPaC8n5UjfMv73fuIRyCmIp13XQ3MPdFM/ kZz3MJQtIVDNCFiz08Hvgi+VUN+qyzk4B/4VdwSrABQvrlF8V/+k5Phx4YrThjV4oSse 33TmfIYgrXj4OqQpfRhUl7jOyT6UV7zgaZIs9fcnmck5L2WU8AcUOzJmtjrWJbK2N04x A9gUpMLc6BFQ345nxq0/bjMrhcpx6q4cFRxeds6stm3njDQB6eF1+5dmlstfDFNUa/6s iKUQ== X-Forwarded-Encrypted: i=1; AJvYcCUKlof6gRY75YCAlUP3SeNcUMdez3O0QtXev8u2kIvKPHlbu5lg+kGniNMu5vdy8SkHVHfcI4J/uqa++yM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5sB85WCeOZoWHS6di+ESr/VtUxyVlJKvqDUMW6f3uaGQFsEVW s8SPjNFrUvUXXyML0tkGXWRw07Nljl3yd4fSAiiuXbCZULX6CFdEeiGEztNg4bMLCLMXS+Hnqt5 5BERTPITHUMHc8SUitUb7Ce3cFJxoq3DTb8N8P8mglAs42SS11tSWBcpGp/NDIngrhaM= X-Gm-Gg: ASbGncviDBNMa5rAWDxmzIjpydjpiHM7sYNPlbTa79PkjLt2NKRVyQefOBgu0Nfehln nXxINCjELXGrHuOKO2IFZ/MLlp3IfnqHl/ir+DRghgA45o+8A7bj3FNKmmaIgAoewJNQNkXMc1G JET+20u83vfVL5CCENaUoji8LNvuO5rthVcYg12vOfH2o7dFiO5SKriOFNyMxkur9vfzKrTUkWu /KL4hRzhY7nBgL+5mpZXvgbkwGYGFra1fb0Go3hjGb9uKpJyUzlbC/ZehfPyf7fiHy8hGTdJrnr Ri5SH5dvbs+YjKqp5kZgMzPVwWkR4FUG8AvC5fMMPGFgTORVftyv2Wv4+8gdtA8qx4sIOl6djp5 HW6oG7j4gJeLFCK2wMJWOPE3SSCTpP8GaaVuoJp/NkR5yrW0SOVF26x40vLFF/rXAag== X-Received: by 2002:ac8:7f54:0:b0:4ee:1588:6186 with SMTP id d75a77b69052e-4f0176844ddmr17307921cf.11.1764760503994; Wed, 03 Dec 2025 03:15:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuDgbijKKd62ii+mc6Bi9vpnrCyOLqg//ZpBlxTts37lCeH5/k75isDDIk/xGo92WQ15EXpw== X-Received: by 2002:ac8:7f54:0:b0:4ee:1588:6186 with SMTP id d75a77b69052e-4f0176844ddmr17307571cf.11.1764760503486; Wed, 03 Dec 2025 03:15:03 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f59aed2esm1781866066b.42.2025.12.03.03.15.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 03:15:02 -0800 (PST) Message-ID: Date: Wed, 3 Dec 2025 12:15:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect param update To: Krishna Kurapati , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Luca Weiss , Abel Vesa , Neil Armstrong , Johan Hovold , Pengyu Luo Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251203083629.2395451-1-krishna.kurapati@oss.qualcomm.com> <20251203083629.2395451-3-krishna.kurapati@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251203083629.2395451-3-krishna.kurapati@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: xLN_g8Pic6z_rJcP80xUljxNRrMmoGFf X-Proofpoint-GUID: xLN_g8Pic6z_rJcP80xUljxNRrMmoGFf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAzMDA4OSBTYWx0ZWRfX8Osj/W/5WqfX u9/25M0fgWYPbkqoYFOyfjKlF/TYZpDByowJhLHBUoYU1HA6lw1tFBlLGRggIW/8pwHZC+rHzCw t6ghQJASf/nu/a0vr4Vd7poFWMcgygvthu6+E0WpEo0759SIPAmIqW7QbPcW91U7+G6yQ+LyRL5 2YnzxBvXRR+MzDfE3lRqzGuIdoKgUjiysWI8/A9efwNRlXtGESugyftVW08HpG6Dlulxn/7E2/k vffeQEDDsUW1WX4zl0e03cokV4+ijlAVS1zotDwSnENI59ByaPuW5w9TX5DXM39AWRdJ5mrNk9N fW00nBBndFTsh+ivGvzKNuvJ3dpkpYwFblhInnRg/XvjBjTv7YRUmOHQJ3DqH2Fnf9ugdVFTxCc rAFheWQlADei8bIMgMeZ2TtlWT5Vcg== X-Authority-Analysis: v=2.4 cv=VoMuwu2n c=1 sm=1 tr=0 ts=69301bb8 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=ZrT6FAlEKn3Pr7If_u8A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-02_01,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 phishscore=0 malwarescore=0 clxscore=1015 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512030089 On 12/3/25 9:36 AM, Krishna Kurapati wrote: > Add support for overriding Squelch Detect parameter. > > Signed-off-by: Krishna Kurapati > --- [...] > struct eusb2_repeater_init_tbl_reg { > unsigned int reg; > unsigned int value; > @@ -120,7 +131,9 @@ static int eusb2_repeater_init(struct phy *phy) > struct regmap *regmap = rptr->regmap; > u32 base = rptr->base; > u32 poll_val; > + s32 dt_val; > int ret; > + int i; > u8 val; > > ret = regulator_bulk_enable(rptr->cfg->num_vregs, rptr->vregs); > @@ -147,6 +160,14 @@ static int eusb2_repeater_init(struct phy *phy) > if (!of_property_read_u8(np, "qcom,tune-res-fsdif", &val)) > regmap_write(regmap, base + EUSB2_TUNE_RES_FSDIF, val); > > + if (!of_property_read_s32(np, "qcom,squelch-detector-bp", &dt_val)) { > + for (i = 0; i < 8; i++) { > + if (squelch_detector[i] == dt_val) > + val = i; > + } > + regmap_write(regmap, base + EUSB2_TUNE_SQUELCH_U, val); How about: if (!of_property..) { for (i = 0; i < ARRAY_SIZE(squelch_detector); i++) { if (squelch_detector[i] == dt_val) { regmap_write() break; } } } We could also validate the value (if none found but property present, error out), but the dt checker already lists all the available values so that may not be necessary Konrad