From: "Wang, Sen" <sen@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-sound@vger.kernel.org>, <lgirdwood@gmail.com>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
<shenghao-ding@ti.com>, <kevin-lu@ti.com>, <baojun.xu@ti.com>,
<niranjan.hy@ti.com>, <l-badrinarayanan@ti.com>,
<devarsht@ti.com>, <v-singh1@ti.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 2/4] ASoC: codecs: Add TAS67524 quad-channel audio amplifier driver
Date: Wed, 15 Apr 2026 09:50:02 -0500 [thread overview]
Message-ID: <fe21165f-e253-4eba-b039-4e82c6f90f93@ti.com> (raw)
In-Reply-To: <dd740c4c-e0bc-4140-961d-6c6c604a594d@sirena.org.uk>
On 4/14/2026 1:08 PM, Mark Brown wrote:
> On Fri, Apr 10, 2026 at 12:56:47PM -0500, Sen Wang wrote:
>> On 4/10/26 09:02, Mark Brown wrote:
>
>>> This looks mostly good, but one issue I see is that AFAICT we only stop
>>> fault_check_work during runtime suspsend - if runtime PM is disabled, or
>>> if the driver is removed, the work will be left running.
>> (snip)
>> Do you think the DAPM fallback would suffice, or is the current approach
>> (poll until removal) acceptable given the hardware behavior? Any other
>> suggestions would be greatly appreciated!
>
> It's fine to keep on checking for faults if there's faults that can be
> generated, the only reason I mentioned runtime PM there was that it's
> the only thing that stops the polling in the current version. So long
> as everything is stopped when the device is removed it's fine. No need
> for a DAPM fallback.
Understood, will make sure services (check_work/IRQ) are canceled when
driver is removed for the next version.
Best,
Sen Wang
next prev parent reply other threads:[~2026-04-15 14:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 22:06 [PATCH v5 0/4] ASoC: Add TAS67524 quad-channel Class-D amplifier driver Sen Wang
2026-04-09 22:06 ` [PATCH v5 1/4] ASoC: dt-bindings: Add ti,tas67524 Sen Wang
2026-04-09 22:06 ` [PATCH v5 2/4] ASoC: codecs: Add TAS67524 quad-channel audio amplifier driver Sen Wang
2026-04-10 14:02 ` Mark Brown
2026-04-10 17:56 ` Sen Wang
2026-04-14 18:08 ` Mark Brown
2026-04-15 14:50 ` Wang, Sen [this message]
2026-04-09 22:06 ` [PATCH v5 3/4] Documentation: sound: Add TAS675x codec mixer controls documentation Sen Wang
2026-04-09 22:06 ` [PATCH v5 4/4] MAINTAINERS: add entry for TAS67524 audio amplifier Sen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe21165f-e253-4eba-b039-4e82c6f90f93@ti.com \
--to=sen@ti.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=krzk+dt@kernel.org \
--cc=l-badrinarayanan@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
--cc=v-singh1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox