From: shuah <shuah@kernel.org>
To: Thomas Renninger <trenn@suse.de>, ego@linux.vnet.ibm.com
Cc: Abhishek Goel <huntbag@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
shuah <shuah@kernel.org>
Subject: Re: [PATCH] cpupower : frequency-set -r option misses the last cpu in related cpu list
Date: Tue, 4 Jun 2019 09:16:12 -0600 [thread overview]
Message-ID: <fe31ff62-da28-3f32-5f9e-171e624213bf@kernel.org> (raw)
In-Reply-To: <1825219.HmmgU4QcfA@house>
On 5/29/19 8:21 AM, Thomas Renninger wrote:
> Hi,
>
> On Wednesday, May 29, 2019 2:12:34 PM CEST Gautham R Shenoy wrote:
>> Hi Abhishek,
>>
>> On Wed, May 29, 2019 at 3:02 PM Abhishek Goel
>
> ...
>
>>> bitmask_setbit(cpus_chosen, cpus->cpu);
>>> cpus = cpus->next;
>>>
>>> }
>>>
>>> + /* Set the last cpu in related cpus list */
>>> + bitmask_setbit(cpus_chosen, cpus->cpu);
>>
>> Perhaps you could convert the while() loop to a do .. while(). That
>> should will ensure
>> that we terminate the loop after setting the last valid CPU.
>
> It would do exactly the same, right?
> IMHO it's not worth the extra hassle of resubmitting. Setting the last value
> outside a while loop is rather common.
>
> I do not have a CPU with related cores at hand.
> If you tested this it would be nice to see this pushed:
>
> Reviewed-by: Thomas Renninger <trenn@suse.de>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/
cpupower branch.
thanks,
-- Shuah
prev parent reply other threads:[~2019-06-04 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 9:30 [PATCH] cpupower : frequency-set -r option misses the last cpu in related cpu list Abhishek Goel
2019-05-29 12:12 ` Gautham R Shenoy
2019-05-29 14:21 ` Thomas Renninger
2019-06-04 15:16 ` shuah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe31ff62-da28-3f32-5f9e-171e624213bf@kernel.org \
--to=shuah@kernel.org \
--cc=ego@linux.vnet.ibm.com \
--cc=huntbag@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox