From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Devesh Sharma <devesh.sharma@broadcom.com>,
linux-rdma <linux-rdma@vger.kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Himanshu Jha <himanshujha199640@gmail.com>
Subject: Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
Date: Mon, 29 Jan 2018 10:31:04 +0100 [thread overview]
Message-ID: <fe3d92c5-8e51-ea72-7637-6545c1654dd3@users.sourceforge.net> (raw)
In-Reply-To: <CANjDDBgyX0d7=5YvgYLew04ODn4hZhfLbvUbvP1BviiEOGWkJQ@mail.gmail.com>
> You don't need 2 patches when changing same lines of code.
Are these really the same?
> Could you squash both and send your changes in a single patch.
I prefer to keep the deletion of questionable error messages separate
from the refactoring for a bit of exception handling.
> The patches look good to me otherwise.
Thanks for your constructive feedback.
Regards,
Markus
next prev parent reply other threads:[~2018-01-29 9:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 20:15 [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl() SF Markus Elfring
2018-01-27 20:16 ` [PATCH 1/2] RDMA/bnxt_re: Delete two error messages for a failed memory allocation in bnxt_qplib_alloc_dpi_tbl() SF Markus Elfring
2018-01-27 20:17 ` [PATCH 2/2] RDMA/bnxt_re: Use common error handling code " SF Markus Elfring
2018-01-29 3:44 ` [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl() Devesh Sharma
2018-01-29 9:31 ` SF Markus Elfring [this message]
2018-01-29 12:08 ` [0/2] " Devesh Sharma
2018-01-29 14:19 ` [PATCH 0/2] " Jonathan Toppins
2018-02-01 22:49 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe3d92c5-8e51-ea72-7637-6545c1654dd3@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=himanshujha199640@gmail.com \
--cc=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).