From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751353AbeA2JbY (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 Jan 2018 04:31:24 -0500
Received: from mout.web.de ([212.227.15.14]:60903 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750913AbeA2JbW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 Jan 2018 04:31:22 -0500
Subject: Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()
To: Devesh Sharma <devesh.sharma@broadcom.com>,
        linux-rdma <linux-rdma@vger.kernel.org>
Cc: Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>,
        Selvin Xavier <selvin.xavier@broadcom.com>,
        Somnath Kotur <somnath.kotur@broadcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Himanshu Jha <himanshujha199640@gmail.com>
References: <19c755a6-8c52-bbd5-a425-48fc08cecd4f@users.sourceforge.net>
 <CANjDDBgyX0d7=5YvgYLew04ODn4hZhfLbvUbvP1BviiEOGWkJQ@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <fe3d92c5-8e51-ea72-7637-6545c1654dd3@users.sourceforge.net>
Date: Mon, 29 Jan 2018 10:31:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <CANjDDBgyX0d7=5YvgYLew04ODn4hZhfLbvUbvP1BviiEOGWkJQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:O3bonJxOpRI3TkQcqqH/IDzJapgYYPukXljOrWy0KT5kZdCXKXB
 vwEkm7PH0Kab0NlB2SSjjScxO96/USROVaVJt1WkTafltvrAEcaYClAXLy9M//RcSsAzY9f
 cBEV+je/jx3DWfJUhKSy0Qa/AjemoxdluS947FhAV1VOATJ4+XVyqfDE/ItVfvxiFjL7PvU
 xsXdY6WLExrAxtLnR6rIQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:t8yiK1KbGEQ=:zOgX42/ONll4U2+o2hiaOI
 Bm/ZMCLY3aXxtgOLm0pTK0BlFzPMNLhVkA2pYOJiyJeK8w7bMPogbv+/V75X53r71oKwInt7F
 FK4OdOh0dLQM/Ofmtk2rODk4t34fabixSyaoslkEnvjQSgoxTLvQ0ntAmzb8laEjDufSAHLg/
 8PEKHEqQQVbJ77HMNoZ++14rZqmSRdIKAJuRDaHjDFiTg6KeRJhbBXrNyo9YpWh5ntXzwAEwq
 SAcY5vDQz3llwICkyco5abK5LOQOC+NlWrVXrQkcJefwo9DrLxyIRY9khVHOHWbnqxE3wog51
 FR1Df8xFB3tITlGq3k6RA/wkunVfHIfCPzumVo74FUPPfEYWhOkX3F0ocB7l2HtzQw+lnGL+k
 L7TMKPjepmeyHJ1rxzZEqMp3WPgsXsDlF68ODo/4TMi9OiZfX2/OfJQRy3cW/XLSs75DMrMPA
 7UgTq0N2OrZ6V4tTCsDiffzM4IFh3H0pcaW4E46IE9oKkZz8x9YWGcYgF/JEGFbnfs4A3BHD7
 4c9SdzIAW8Pw8SStiF71VZFfYc0HCMPl0kYmaC2Dvk/sVMWgNf6U4a6Gvur5TK4XEHtaygzzb
 IOvDAiH944oD1v94IAMXfVT2bFxqqoYNZGEs4+uY7l6mooS562MMYAv8NRQDjKVz/rpn20x/u
 o7H8E/8bU2+Z6xMmmcaTkhcreMj9vCb9chMVdGrGP6XAOaHxeODLLSmP91gWwD+QHRH7xrDOS
 aE7FZq7smubtYA/aQAo8XI0/Dx5xwS0DjSjOKy5PgTM+4GoFGpvOQbJE/sqTq4nXrGy0U4O9G
 bkxx82nvtZK0TgS97aB9LDWaUk1icG+JLKaqX8WHCES4Y3wjrc=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> You don't need 2 patches when changing same lines of code.

Are these really the same?


> Could you squash both and send your changes in a single patch.

I prefer to keep the deletion of questionable error messages separate
from the refactoring for a bit of exception handling.


> The patches look good to me otherwise.

Thanks for your constructive feedback.

Regards,
Markus