From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B900C77B73 for ; Mon, 8 May 2023 11:19:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235442AbjEHLTn (ORCPT ); Mon, 8 May 2023 07:19:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235547AbjEHLTk (ORCPT ); Mon, 8 May 2023 07:19:40 -0400 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 838B237C6D; Mon, 8 May 2023 04:19:37 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R241e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=17;SR=0;TI=SMTPD_---0Vi4aMn6_1683544771; Received: from 30.221.149.87(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0Vi4aMn6_1683544771) by smtp.aliyun-inc.com; Mon, 08 May 2023 19:19:32 +0800 Message-ID: Date: Mon, 8 May 2023 19:19:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 0/5] Add JSON metrics for arm CMN and Yitian710 DDR To: Ian Rogers Cc: John Garry , Will Deacon , Shuai Xue , James Clark , Mike Leach , Leo Yan , Mark Rutland , Ilkka Koskinen , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Zhuo Song References: <1682329456-19418-1-git-send-email-renyu.zj@linux.alibaba.com> From: Jing Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/4/30 上午5:01, Ian Rogers 写道: > On Mon, Apr 24, 2023 at 2:44 AM Jing Zhang wrote: >> >> Changes since RFC: >> - Refact arm-cmn PMU identifier. >> - Not add arm-cmn PMU aliasing currently because it's Eventcode is >> difficult to define. >> - Rename ali_drw PMU identifier and Unit name. >> - Divide ali_drw PMU metric and aliasing into two patches. >> >> Add an identifier sysfs file for the yitian710 SoC DDR and arm CMN to >> allow userspace to identify the specific implementation of the device, >> so that the perf tool can match the corresponding uncore events and >> metrics through the identifier. Then added several general CMN700 metrics >> and yitian710 soc DDR metrics. >> >> $perf list: >> ... >> ali_drw: >> hif_rmw >> [A Read-Modify-Write Op at HIF interface. 64B. Unit: ali_drw] >> hif_hi_pri_rd >> [A high priority Read at HIF interface. 64B. Unit: ali_drw] >> hif_rd >> [A Read Op at HIF interface. 64B. Unit: ali_drw] >> hif_rd_or_wr >> [A Write or Read Op at HIF interface. 64B. Unit: ali_drw] >> hif_wr >> [A Write Op at HIF interface. 64B. Unit: ali_drw] >> ... >> >> $perf stat -M ddr_read_bandwidth.all ./test >> >> Performance counter stats for 'system wide': >> >> 38,150 hif_rd # 2.4 MB/s ddr_read_bandwidth.all >> 1,000,957,941 ns duration_time >> >> 1.000957941 seconds time elapsed >> >> Jing Zhang (5): >> driver/perf: Add identifier sysfs file for CMN >> perf vendor events: Add JSON metrics for CMN-700 >> driver/perf: Add identifier sysfs file for Yitian 710 DDR >> perf jevents: Add support for Yitian 710 DDR PMU aliasing >> perf vendor events: Add JSON metrics for Yitian 710 DDR > > The perf tool changes all make sense. John Garry is more of an expert > on the ARM part of this than me though. > Acked-by: Ian Rogers > Thanks Ian!