From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH v7 03/12] perf session: define bytes_transferred and bytes_compressed metrics
Date: Tue, 12 Mar 2019 08:15:11 +0300 [thread overview]
Message-ID: <fe521e87-d255-3cad-19a2-e082ee47d3ea@linux.intel.com> (raw)
In-Reply-To: <5f3a8326-58a0-816e-ad61-31c111232c7a@linux.intel.com>
Define bytes_transferred and bytes_compressed metrics to calculate ratio
in the end of the data collection:
compression ratio = bytes_transferred / bytes_compressed
bytes_transferred accumulates the amount of bytes that was extracted from
the mmaped kernel buffers for compression. bytes_compressed accumulates
the amount of bytes that was received after applying compression.
Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
---
tools/perf/builtin-record.c | 14 +++++++++++++-
tools/perf/util/env.h | 1 +
tools/perf/util/session.h | 2 ++
3 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 736a0f008959..bc0a895e7e80 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -1502,6 +1502,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
char samples[128];
const char *postfix = rec->timestamp_filename ?
".<timestamp>" : "";
+ float ratio = 0;
if (rec->samples && !rec->opts.full_auxtrace)
scnprintf(samples, sizeof(samples),
@@ -1509,9 +1510,20 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
else
samples[0] = '\0';
- fprintf(stderr, "[ perf record: Captured and wrote %.3f MB %s%s%s ]\n",
+ if (rec->session->bytes_transferred && rec->session->bytes_compressed) {
+ ratio = (float)rec->session->bytes_transferred/(float)rec->session->bytes_compressed;
+ session->header.env.comp_ratio = ratio + 0.5;
+ }
+
+ fprintf(stderr, "[ perf record: Captured and wrote %.3f MB %s%s%s",
perf_data__size(data) / 1024.0 / 1024.0,
data->path, postfix, samples);
+ if (ratio) {
+ fprintf(stderr, ", compressed (original %.3f MB, ratio is %.3f)",
+ rec->session->bytes_transferred / 1024.0 / 1024.0,
+ ratio);
+ }
+ fprintf(stderr, " ]\n");
}
out_delete_session:
diff --git a/tools/perf/util/env.h b/tools/perf/util/env.h
index d01b8355f4ca..fb39e9af128f 100644
--- a/tools/perf/util/env.h
+++ b/tools/perf/util/env.h
@@ -64,6 +64,7 @@ struct perf_env {
struct memory_node *memory_nodes;
unsigned long long memory_bsize;
u64 clockid_res_ns;
+ u32 comp_ratio;
};
extern struct perf_env perf_env;
diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h
index d96eccd7d27f..0e14884f28b2 100644
--- a/tools/perf/util/session.h
+++ b/tools/perf/util/session.h
@@ -35,6 +35,8 @@ struct perf_session {
struct ordered_events ordered_events;
struct perf_data *data;
struct perf_tool *tool;
+ u64 bytes_transferred;
+ u64 bytes_compressed;
};
struct perf_tool;
--
2.20.1
next prev parent reply other threads:[~2019-03-12 5:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 4:57 [PATCH v7 00/12] perf: enable compression of record mode trace to save storage space Alexey Budankov
2019-03-12 5:03 ` [PATCH v7 01/12] feature: implement libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines Alexey Budankov
2019-03-12 5:12 ` [PATCH v7 02/12] perf record: implement -f,--mmap-flush=<threshold> option Alexey Budankov
2019-03-13 14:36 ` Jiri Olsa
2019-03-13 15:00 ` Alexey Budankov
2019-03-12 5:15 ` Alexey Budankov [this message]
2019-03-12 5:17 ` [PATCH v7 04/12] perf record: implement COMPRESSED event record and its attributes Alexey Budankov
2019-03-12 5:20 ` [PATCH v7 05/12] perf mmap: implement dedicated memory buffer for data compression Alexey Budankov
2019-03-12 5:23 ` [PATCH v7 06/12] perf util: introduce Zstd based streaming compression API Alexey Budankov
2019-03-13 14:37 ` Jiri Olsa
2019-03-13 15:06 ` Alexey Budankov
2019-03-12 5:25 ` [PATCH v7 07/12] perf record: implement compression for serial trace streaming Alexey Budankov
2019-03-12 5:30 ` [PATCH v7 08/12] perf record: implement compression for AIO " Alexey Budankov
2019-03-13 14:36 ` Jiri Olsa
2019-03-13 15:33 ` Alexey Budankov
2019-03-13 14:37 ` Jiri Olsa
2019-03-12 5:32 ` [PATCH v7 09/12] perf record: implement -z,--compression_level=n option Alexey Budankov
2019-03-12 5:36 ` [PATCH v7 10/12] perf report: implement record trace decompression Alexey Budankov
2019-03-13 14:37 ` Jiri Olsa
2019-03-13 15:55 ` Alexey Budankov
2019-03-14 9:01 ` Jiri Olsa
2019-03-12 5:37 ` [PATCH v7 11/12] perf inject: enable COMPRESSED records decompression Alexey Budankov
2019-03-12 5:38 ` [PATCH v7 12/12] perf tests: implement Zstd comp/decomp integration test Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe521e87-d255-3cad-19a2-e082ee47d3ea@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox