Re: 2.6.12-rc3-mm1

Coywolf Qi Hunt
2005-04-30T18:31:04Z

On 4/30/05, Adrian Bunk <bunk@stusta.de> wrote:
> On Fri, Apr 29, 2005 at 11:16:53PM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.12-rc2-mm3:
> >...
> > +x86-x86_64-deferred-handling-of-writes-to-proc-irq-xx-smp_affinitypatch-added-to-mm-tree.patch
> >
> > x86_64 updates
> >...
>
> This patch contains at least two bugs:
>
> The static inline set_irq_info() is not available
> for CONFIG_GENERIC_PENDING_IRQ=n, resulting in the following warning:
>
> <-- snip -->
>
> ...
> CC arch/i386/kernel/io_apic.o
> arch/i386/kernel/io_apic.c: In function `set_ioapic_affinity_irq':
> arch/i386/kernel/io_apic.c:251: warning: implicit declaration of function `set_irq_info'
> ...
>
> <-- snip -->
>
> The second bug is that although irq.h defines set_irq_info() as a static
> inline, this patch adds an empty function to kernel/irq/manage.c .
>
> The second bug shadows the first bug, but both have to be fixed.

IMHO, there are no bugs at all, or at least not the kind of bugs you think.

--
Coywolf Qi Hunt