From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: "Limonciello, Mario" <mlimonci@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Natikar Basavaraj <Basavaraj.Natikar@amd.com>,
Donghun Yoon <donghun.yoon@lge.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xhci-pci: Only run d3cold avoidance quirk for s2idle
Date: Thu, 4 May 2023 10:51:49 +0300 [thread overview]
Message-ID: <fe7dd886-99b1-bcce-2c3d-fe8aa2bbff6d@linux.intel.com> (raw)
In-Reply-To: <ac090da4-6cec-8c5a-22ac-36e130cb201a@amd.com>
On 3.5.2023 16.59, Limonciello, Mario wrote:
>
> On 5/3/2023 8:14 AM, Mathias Nyman wrote:
>> On 25.4.2023 0.48, Mario Limonciello wrote:
>>> Donghun reports that a notebook that has an AMD Ryzen 5700U but supports
>>> S3 has problems with USB after resuming from suspend. The issue was
>>> bisected down to commit d1658268e439 ("usb: pci-quirks: disable D3cold on
>>> xhci suspend for s2idle on AMD Renoir").
>>>
>>> As this issue only happens on S3, narrow the broken D3cold quirk to only
>>> run in s2idle.
>>>
>>> Fixes: d1658268e439 ("usb: pci-quirks: disable D3cold on xhci suspend for s2idle on AMD Renoir")
>>> Reported-and-tested-by: Donghun Yoon <donghun.yoon@lge.com>
>>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>>> ---
>>> v1->v2:
>>> * Guard against CONFIG_SUSPEND not being set
>>
>> Thanks,
>> Checkpatch complains that it wants a link to the issue after a "Reported-by:" tag.
>>
>> Is there any public report of this?
>>
>> Thanks
>> Mathias
>>
>>
> It was reported privately to me by Donghun, and they confirmed from private testing
> that this change helps the issue.
>
> I noticed that message from checkpatch too before I sent this up, but I figured it's better
> to give Donghun attribution rather than drop the tag.
>
Agree, thanks for the info
Mathias
prev parent reply other threads:[~2023-05-04 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 21:48 [PATCH v2] xhci-pci: Only run d3cold avoidance quirk for s2idle Mario Limonciello
2023-05-03 13:14 ` Mathias Nyman
2023-05-03 13:59 ` Limonciello, Mario
2023-05-04 7:51 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe7dd886-99b1-bcce-2c3d-fe8aa2bbff6d@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=donghun.yoon@lge.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mathias.nyman@intel.com \
--cc=mlimonci@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox