From: Arjan van de Ven <arjan@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Borislav Petkov <bp@alien8.de>,
Noah Goldstein <goldstein.w.n@gmail.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] x86/misc for 6.5
Date: Tue, 27 Jun 2023 16:05:31 -0700 [thread overview]
Message-ID: <fe807f09-9e4a-52d6-c057-b159bee55510@linux.intel.com> (raw)
In-Reply-To: <CAHk-=wgtrxkRDR95y=U685LMd_ZR5TrLW0_LGoQi3v8Or11Yrw@mail.gmail.com>
On 6/27/2023 4:02 PM, Linus Torvalds wrote:
> On Tue, 27 Jun 2023 at 15:51, Arjan van de Ven <arjan@linux.intel.com> wrote:
>>
>> I'm not surprised though; running 2 parallel streams (where one stream has a fixed zero as input,
>> so can run OOO any time) .. can really have a performance change like this
>
> How much do people care?
>
> One of the advantages of just having that single "update_csum_40b()"
> function is that it's trivial to then manually unroll.
>
> With a 4-way unrolling, I get
>
> 02: 184.0 / 184.5 cycles (8b414316) Upcoming linux kernel version
> 04: 184.0 / 184.2 cycles (8b414316) Specialized to size 40
> 06: 89.4 / 102.5 cycles (512daed6) New version
> 22: 184.6 / 184.4 cycles (8b414316) Odd-alignment handling removed
>
> but doesn't most network hardware do the csum on its own anyway? How
> critical is csum_partial(), really?
the hardware does most cases..
in
https://lore.kernel.org/netdev/20211111181025.2139131-1-eric.dumazet@gmail.com/
Eric kind of implies it's for IPv6 headers in practice
next prev parent reply other threads:[~2023-06-27 23:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 11:00 [GIT PULL] x86/misc for 6.5 Borislav Petkov
2023-06-27 20:11 ` Linus Torvalds
2023-06-27 20:26 ` Linus Torvalds
2023-06-27 20:38 ` Borislav Petkov
2023-06-27 20:49 ` Linus Torvalds
2023-06-27 21:11 ` Borislav Petkov
2023-06-27 21:44 ` Linus Torvalds
2023-06-27 21:58 ` Linus Torvalds
2023-06-27 21:44 ` Arjan van de Ven
2023-06-27 22:25 ` Linus Torvalds
2023-06-27 22:43 ` Linus Torvalds
2023-06-27 22:50 ` Arjan van de Ven
2023-06-27 23:02 ` Linus Torvalds
2023-06-27 23:05 ` Arjan van de Ven [this message]
2023-06-29 5:29 ` Herbert Xu
2023-06-27 20:52 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe807f09-9e4a-52d6-c057-b159bee55510@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=goldstein.w.n@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox