From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbcIOS1X (ORCPT ); Thu, 15 Sep 2016 14:27:23 -0400 Received: from mout.web.de ([212.227.17.11]:65054 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794AbcIOS1W (ORCPT ); Thu, 15 Sep 2016 14:27:22 -0400 Subject: Re: [PATCH 6/7] AGPGART-UniNorth: Rename a jump label in uninorth_create_gatt_table() References: <201609160122.hY7g8HCC%fengguang.wu@intel.com> Cc: kbuild test robot , kbuild-all@01.org, LKML , Julia Lawall To: kernel-janitors@vger.kernel.org, David Airlie From: SF Markus Elfring Message-ID: Date: Thu, 15 Sep 2016 20:26:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <201609160122.hY7g8HCC%fengguang.wu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:eOrUdytrq+r0mqoTaGCqf3h5OE9PL6QJvLbeTmKxMRvR5+lDwl7 zcykUAAtZR0yfSpD8h3yJFGmwTm58FUDABLdB24XuvWP2T/dtlM8EuDmhGEE5JJigad5DsB mQLMS/AA+RIRbyqLKbFbZm0qlgFCsS4UIXhkwVwoC3kCN3jTv+zoGjGa3FEArsCXjBtISNp CZoAhobxiSD+Aym7SMsdA== X-UI-Out-Filterresults: notjunk:1;V01:K0:3ucy7LtJyGI=:txoCBV5c8mRhfpIJ4qWJPe 7aE8dUbW7l/kfmUte8VHC7bJV9MVPIP0Vsk3uhX0JA/RlrsHkOf8RHL6WZkmuS9BzUNLB9UVx WiYpnMIadeZJRI5mGXUjkjFAIYD4pWwfN6aBhCcs9Ug/SYMeCgqmied+VSI+LwhtOr/IhnRZ3 XUzVArQY1jj1rlgIjH5HCG1iDBJ6tnyxa+BO4ASfBw6D3kpSos/cFlA3/aXXGASsAIoibZemO a3YL6GFDR1KLt6INUTGfkCpF8pQgPpx3XBh+UEJAX7CnIyy6njJTMtS4jHLdTdrde4AthcAfG IpgaQNltzD7ydwNfA4E0v0YXk3MaVDUUXnjf6MVLGObGu6Bm8ubpxI0Oti2Wp7DPh69hoW5G0 yy7SKsZ6+pqTIMRSHNDNiQ8sVhY6+Aswz4CppmDWL5VuaIeeGQ47DhnDWTUZekTVVo23tBO9+ HhGoJMNpXv+jbAHWyGADls18OqAM2e9F83hiIPajmgWrepsm9unA8JgGeP4mah/oam6qIavxb /ox2GYCRhdoFqhXll9MpORW0gw5M34YBtfex/sWPr8YszZhetnJapiwxZeO9bHesz4q/9RqJK pf0UdaVgw9BZ2mqfu/Y4AYqKqpSTnR6u6+7CTrnJ3NwKFox1S9Kqv1GQ7FNkN5lYch/CIK4mo ZXLMhIgGsbX5AJRTpVeV+TOMjJfcNxylF9gz+BlZx/u02qriCV5wL1ajma8UlYXhHSZG4DkpT 29g9KAbfYIm/P1rnnraY1k/N0N5LthmHU4YLa3KVZgB7fMrEfW/QZ0QrDma7lMD7J7eng5JeP oHbR0HH Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > drivers/char/agp/uninorth-agp.c: In function 'uninorth_create_gatt_table': >>> drivers/char/agp/uninorth-agp.c:426:3: error: label 'enomem' used but not defined > goto enomem; > ^ > > vim +/enomem +426 drivers/char/agp/uninorth-agp.c This error message points a glitch out which was triggered by my update suggestion. Unfortunately, it means that the proposed renaming of such an identifier was incomplete at this source code place. In which ways would you like to improve the shown software situation? * Would you like to fix a single identifier anyhow directly? * Do you expect that I should resend a corrected patch series as a whole package? * Would it be sufficient to send another update only for the software module "AGPGART-UniNorth" a bit later? * Can I worry about this programming mistake a bit less just because the suggested renaming would eventually be rejected? Regards, Markus