From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Denzeel Oliva <wachiturroxd150@gmail.com>,
andi.shyti@kernel.org, broonie@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com,
peter.griffin@linaro.org, andre.draszik@linaro.org,
linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/2] spi: s3c64xx: add support exynos990-spi to new port config data
Date: Thu, 13 Feb 2025 07:10:54 +0000 [thread overview]
Message-ID: <feefbcf2-e441-4cd1-a3de-40bfd4d7197a@linaro.org> (raw)
In-Reply-To: <20250212191241.280-3-wachiturroxd150@gmail.com>
On 2/12/25 7:12 PM, Denzeel Oliva wrote:
> +static const struct s3c64xx_spi_port_config exynos990_spi_port_config = {
> + /* fifo-depth must be specified in the device tree. */
> + .fifo_depth = 0,
have you tried testing without specifying the fifo_depth in DT?
You'll probably hit a divide by zero at:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/spi/spi-s3c64xx.c#n664
I assume the controller can work with 0 sized FIFO depth, and if so, the
driver has to be updated to allow 0 sized FIFOs.
btw, how did you test the set?
next prev parent reply other threads:[~2025-02-13 7:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 19:12 [PATCH v1 0/2] spi: s3c64xx: add support for samsung,exynos990-spi Denzeel Oliva
2025-02-12 19:12 ` [PATCH v1 1/2] spi: dt-bindings: samsung: add samsung,exynos990-spi compatible Denzeel Oliva
2025-02-12 19:12 ` [PATCH v1 2/2] spi: s3c64xx: add support exynos990-spi to new port config data Denzeel Oliva
2025-02-13 7:10 ` Tudor Ambarus [this message]
2025-02-13 7:05 ` [PATCH v1 0/2] spi: s3c64xx: add support for samsung,exynos990-spi Tudor Ambarus
2025-02-13 19:47 ` Denzeel Oliva
2025-02-14 6:14 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feefbcf2-e441-4cd1-a3de-40bfd4d7197a@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=wachiturroxd150@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox