From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763840AbdAIT6j (ORCPT ); Mon, 9 Jan 2017 14:58:39 -0500 Received: from gateway32.websitewelcome.com ([192.185.144.98]:44391 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbdAIT6i (ORCPT ); Mon, 9 Jan 2017 14:58:38 -0500 X-Greylist: delayed 1363 seconds by postgrey-1.27 at vger.kernel.org; Mon, 09 Jan 2017 14:58:38 EST Message-ID: In-Reply-To: References: <1481914491-21456-1-git-send-email-sbates@raithlin.com> Date: Mon, 9 Jan 2017 13:35:46 -0600 Subject: Re: [PATCH 0/2] nvme: Improvements in sysfs entry for NVMe CMBs From: "Stephen Bates" To: "Jens Axboe" Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, sagi@grimberg.me, james_p_freyensee@linux.intel.com, jonathan.derrick@intel.com User-Agent: SquirrelMail/1.5.2 [SVN] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - estate.websitewelcome.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [1547 32008] / [47 12] X-AntiAbuse: Sender Address Domain - raithlin.com X-BWhitelist: no X-Source-IP: X-Exim-ID: 1cQfjO-0001sg-1N X-Source: X-Source-Args: /usr/local/cpanel/3rdparty/php/54/bin/php-cgi /usr/local/cpanel/base/3rdparty/squirrelmail/src/compose.php X-Source-Dir: /usr/local/cpanel/base/3rdparty/squirrelmail/src X-Source-Sender: X-Source-Auth: raithlin X-Email-Count: 6 X-Source-Cap: cmFpdGhsaW47c2NvdHQ7ZXN0YXRlLndlYnNpdGV3ZWxjb21lLmNvbQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > I have added 1/2, since that one is a no-brainer. For 2/2, not so sure. > Generally we try to avoid having sysfs file that aren't single value > output. That isn't a super hard rule, but it is preferable. > > -- > Jens Axboe > Thanks Jens and sorry for the delay (extended vacation). Thanks for pulling 1/2. I will go take a look at 2/2. Stephen