From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf list: Skip the invalid hybrid pmu
Date: Wed, 7 Jul 2021 15:24:23 +0800 [thread overview]
Message-ID: <ff0c48bb-2cbf-766a-f726-bb7a287375b4@linux.intel.com> (raw)
In-Reply-To: <YOS1119y56eH0Uyv@krava>
Hi Jiri,
On 7/7/2021 3:58 AM, Jiri Olsa wrote:
>> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
>> index 88c8ecdc60b0..281670e9c4bd 100644
>> --- a/tools/perf/util/pmu.c
>> +++ b/tools/perf/util/pmu.c
>> @@ -1604,6 +1604,9 @@ void print_pmu_events(const char *event_glob, bool name_only, bool quiet_flag,
>> pmu = NULL;
>> j = 0;
>> while ((pmu = perf_pmu__scan(pmu)) != NULL) {
>> + if (perf_pmu__is_invalid_hybrid(pmu->name))
>> + continue;
> hum why not detect it in pmu_lookup early on
> and not add that pmu at all?
>
> thanks,
> jirka
>
Yes, it's a good idea that detects it in pmu_lookup, thanks!
Thanks
Jin Yao
prev parent reply other threads:[~2021-07-07 7:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 5:16 [PATCH] perf list: Skip the invalid hybrid pmu Jin Yao
2021-06-16 16:37 ` Andi Kleen
2021-07-06 2:27 ` Jin, Yao
2021-07-06 19:58 ` Jiri Olsa
2021-07-07 7:24 ` Jin, Yao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff0c48bb-2cbf-766a-f726-bb7a287375b4@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox