Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

[Thomas Zimmermann <tzimmermann@suse.de>]

Hi

Am 25.02.25 um 09:02 schrieb Aditya Garg:
>
>> On 25 Feb 2025, at 1:27 PM, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>>
>> Hi
>>
>> Am 24.02.25 um 17:58 schrieb Aditya Garg:
>> [...]
>>>> +config DRM_APPLETBDRM
>>>> +    tristate "DRM support for Apple Touch Bars"
>>>> +    depends on DRM && USB && MMU
>>>> +    select DRM_GEM_SHMEM_HELPER
>>>> +    select DRM_KMS_HELPER
>>>> +    select HID_APPLETB_BL
>>> Btw I have a doubt regarding this dependency. While hid-appletb-bl has made into the linux-next tree, it has still not been merged into Linus' tree, and neither the drm tree I assume. It potentially could cause issues?
>> Yes. We cannot merge this driver until we have this symbol in our tree. But that will happen sooner or later.
>>
>> More problematic is that your driver selects HID_APPLETB_BL. From what I've seen, this symbol is user configurable, so the driver shouldn't select it. You need to use 'depends on' instead of 'select' here.
> I assume we need the same for HID_MULTITOUCH as well, since it's needed for the touch feedback.

Indeed. Same goes for HID_MULTITOUCH.

Best regards
Thomas

>> Best regards
>> Thomas
>>
>>>> +    select HID_MULTITOUCH
>>>> +    help
>>>> +      Say Y here if you want support for the display of Touch Bars on x86
>>>> +      MacBook Pros.
>>>> +
>>>> +      To compile this driver as a module, choose M here: the
>>>> +      module will be called appletbdrm.
>>>> +
>> --
>> --
>> Thomas Zimmermann
>> Graphics Driver Developer
>> SUSE Software Solutions Germany GmbH
>> Frankenstrasse 146, 90461 Nuernberg, Germany
>> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
>> HRB 36809 (AG Nuernberg)
>>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)