From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F0132145A0B for ; Tue, 31 Dec 2024 06:59:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735628385; cv=none; b=pa/WebatgtyC44pqV8fchNLoHs1m6aiuborXqf/dM5tAuO9lCbLACMW1XBFegtaLBBm09W0uIE9wJ65lGhT7CvjFAMeS5G6eUcvf6vyYdfju9grlAalTGyT/cu+ZugGrxrgckXD/hHNGNjKXOlGQwb319IQO5scQia1MMdOykuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735628385; c=relaxed/simple; bh=ltGU6ml6NHmtdYvA4DFgMoRBPtPuYUVjoitXx8dOmUI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rJM7pgEMbWMtaeGEF6LiM5I83b9Vbo0EgMcGy2Bw/IcT8oPlSs+XaRbCrNN+Xu6ic8DgrlRWVSFoEXN1pBRLoYewgyUQdwMCTFfSWLXuLbpnNaeiK0cCB+NTfNanzxKoPF7ESIvVJVSVoXaGunL44DdnF1V0kaBnFAIObTVTslo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 529D81424; Mon, 30 Dec 2024 23:00:10 -0800 (PST) Received: from [10.163.53.15] (unknown [10.163.53.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 071B23F6A8; Mon, 30 Dec 2024 22:59:36 -0800 (PST) Message-ID: Date: Tue, 31 Dec 2024 12:29:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: mm: implement vmemmap_check_pmd for arm64 To: Zhenhua Huang , Catalin Marinas Cc: will@kernel.org, ardb@kernel.org, ryan.roberts@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, dave.hansen@linux.intel.com, akpm@linux-foundation.org, chenfeiyang@loongson.cn, chenhuacai@kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241209094227.1529977-1-quic_zhenhuah@quicinc.com> <20241209094227.1529977-3-quic_zhenhuah@quicinc.com> <39a85800-47c5-4529-906d-5a40e58ce136@arm.com> <8685ca94-1382-45c0-a3c3-4b5ccf244057@quicinc.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <8685ca94-1382-45c0-a3c3-4b5ccf244057@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit A very small nit regarding the subject line. The callback vmemmap_check_pmd() is already present on arm64 platform which is rather incomplete. Something like this might be better. arm64/mm: Test for pmd_sect() in vmemmap_check_pmd() On 12/30/24 13:18, Zhenhua Huang wrote: > > > On 2024/12/27 10:57, Anshuman Khandual wrote: >> However it does not really check the entry to be a section mapping which it should. >> Returning pmd_sect(READ_ONCE(*pmdp)) is the right thing, which should have been the >> case from the beginning when vmemmap_check_pmd() was added. I guess because arm64's >> original vmemmap_populate() checked only for vmemmap_verify() as well. So probably >> this does not need a "Fixes: " tag. > > Hi Anshuman, > > I agree, will remove "Fixes: " tag in next patchset Could you please send a V3 of this patch separately instead and not part of this series as they are not really related. But after implementing the following changes 1) Use READ_ONCE() as indicated earlier 2) Drop the "Fixes: " tag 3) Update the commit message explaining why pmd_sect() is required here and how the originally commit missed that 4) Update the subject line