From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752466AbdJ0NMs (ORCPT <rfc822;w@1wt.eu>);
        Fri, 27 Oct 2017 09:12:48 -0400
Received: from mout.web.de ([212.227.17.12]:63911 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752222AbdJ0NMp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Oct 2017 09:12:45 -0400
Subject: Re: iio/light/gp2ap020a00f: Use common error handling code in
 gp2ap020a00f_adjust_lux_mode()
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Hartmut Knaack <knaack.h@gmx.de>,
        Jacek Anaszewski <j.anaszewski@samsung.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <06da0424-1ec9-209e-a433-48288c49132b@users.sourceforge.net>
 <20171026173113.371995f3@archlinux>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <ffaa6d77-4bcc-10f4-6c1d-6c53fee158ba@users.sourceforge.net>
Date: Fri, 27 Oct 2017 15:12:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171026173113.371995f3@archlinux>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:Bds0k+hyPS/Ib65DqVBHpIhSBrJuMUGPN0KyN4K90omTpFe9C78
 HgU3fstzUVimM4uvJeCbYj2ra/pzv1hvX+fkIOuIeIXQ3pvzhRV+Tk4tPJO8X9tT3cQlyY1
 bz6j6qJ/CFbS5RhiuImzDqRx0EdAxrHno7/JHfLwgf7Ew4TC078uhKcRrb5uESOg1hpW3gR
 0jVEGT161T5vKCX4xAm7Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:NSugYkqgu5k=:N2f6CpAFkZN6dddL6et4xC
 a3IDXMn64pf8OID91Ij8mGaiOwDFiIvQ42qOPy/7JfPb5mbIH89RMNickqdSugNqHBE8yIqml
 FaVeDGc9XreO+OukXd8txnORdq92oYzihYVLddAfDWO/0v2oaItpJxXm1oFMISYceRjrBf8u3
 fjhfgfMyx61s401y9WMtH4P5cDjC1zFw7zcirIjX+U3CpbPrNEUhXxXmN3FlzHJC1nFeigFwJ
 sx6phWAkGXG2+HhTQvxG91E25LcLVFkpzG6izdRgsj3b+l0ZN789tcQZNqZykwh/XaKrcetZM
 yo5Zd/nU5dV9ZD1fstpig19LqASssm5OaelrP+Fw8Ppy1AK8C7qZrqlLZuGC0yWQWg8McdUzt
 zpCgEQn8odIWH1flvdH/z3LB6cuw6sSCDZtF1uALIgCq9yQrFU3CKB8woaxbjcOzsVW9GUYz0
 AuyBWB4lij0aJO0X8eiBsmcgjV8GIrKVGUKEZdbl0RhmxcAVRCOi8/XdVzfMDKSADCwrXrTdy
 jkLVgbsdMqzK4J4BxItbwuLiscN+JdIbaD9SFKDnx4uXFBF9/TiGcSiQ97k7o8q4TK51V0Wgb
 XiWznOs4JKkdT/u2fYkTUruNze0XMml2YsSXAtAvqf7aH8fBCrUJFpWaBP0zsRLtxmnXdnPx9
 Feq36qH8HbUEo4p6KxheqhGttL5kDj3QQwlwKrnOM4tyGgtyZ2a7dDIAnwSQSxpII7uVB4iCj
 uOhw4rNiBdqqIu6V49TiHIlKobodooWJTfn5eqeKSZc96QtCTXbh4fbiaMrOXBHSBs4OvK594
 9r7JTO9ueMB9t/CBmnP9rZfNYfqS31PF0VzNDS1gUljNEwt95A=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Same issue - readability is worse

An alternative opinion triggered the development also of this update suggestion.


> than without the patch so it is always going to be rejected.

Corresponding clarification might be needed if the change (in a direction
I propose here) will become desirable.
Can it make sense to concentrate a bit of error reporting at the end
of such a function?

Regards,
Markus