From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Nico Pache <npache@redhat.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Cc: Usama Arif <usama.arif@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>, Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <liam@infradead.org>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 2/7] mm/khugepaged: extract young page check into collapse_is_referenced() helper
Date: Wed, 29 Jul 2026 11:47:00 +0200 [thread overview]
Message-ID: <ffb091ee-affe-41b2-939c-6437dd9cc13e@kernel.org> (raw)
In-Reply-To: <20260715025941.1571316-3-npache@redhat.com>
On 7/15/26 04:59, Nico Pache wrote:
> This change deduplicates the "is this PTE/folio referenced enough to be
> considered for a collapse" condition that was repeated in both
> __collapse_huge_page_isolate() and collapse_scan_pmd(), extracting it into
> a single inline helper function.
>
> Also move the comment and use it as the function header. While we are at
> it, updated the comment to clarify that a young pte is a recently accessed
> one.
>
> Acked-by: Usama Arif <usama.arif@linux.dev>
> Signed-off-by: Nico Pache <npache@redhat.com>
> ---
Also, do we really need this (badly named :) ) helper given that there will only
be a single invocation after #5?
--
Cheers,
David
next prev parent reply other threads:[~2026-07-29 9:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 2:59 [PATCH v2 0/7] mm/khugepaged: several cleanups Nico Pache
2026-07-15 2:59 ` [PATCH v2 1/7] mm/khugepaged: refactor per-scan state clearing into collapse_control_init_scan() Nico Pache
2026-07-29 9:39 ` David Hildenbrand (Arm)
2026-07-15 2:59 ` [PATCH v2 2/7] mm/khugepaged: extract young page check into collapse_is_referenced() helper Nico Pache
2026-07-29 9:41 ` David Hildenbrand (Arm)
2026-07-29 9:41 ` David Hildenbrand (Arm)
2026-07-29 9:47 ` David Hildenbrand (Arm) [this message]
2026-07-15 2:59 ` [PATCH v2 3/7] mm/khugepaged: introduce a count_collapse_event() helper Nico Pache
2026-07-29 9:43 ` David Hildenbrand (Arm)
2026-07-15 2:59 ` [PATCH v2 4/7] mm/khugepaged: fix outdated comments Nico Pache
2026-07-29 9:44 ` David Hildenbrand (Arm)
2026-07-15 2:59 ` [PATCH v2 5/7] mm/khugepaged: Refactor the PTE state checks into a helper Nico Pache
2026-07-15 2:59 ` [PATCH v2 6/7] mm/khugepaged: unmap pte before releasing vma write lock Nico Pache
2026-07-29 9:48 ` David Hildenbrand (Arm)
2026-07-15 2:59 ` [PATCH v2 7/7] mm: Documentation: clarify where the mTHP stats live Nico Pache
2026-07-29 9:48 ` David Hildenbrand (Arm)
2026-07-15 4:41 ` [PATCH v2 0/7] mm/khugepaged: several cleanups Andrew Morton
2026-07-15 5:59 ` Nico Pache
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffb091ee-affe-41b2-939c-6437dd9cc13e@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=corbet@lwn.net \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox