From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 879A9331A57 for ; Mon, 4 May 2026 08:26:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777883191; cv=none; b=EqPpTsKD8KJM1j3H3w15CNdr/JA3Ys0Wc78rldaH9WUICen2hymnGvnRXmPVSHAtQ/s4XyOiR/z3nwBzoM4LwlDOKlr1Z+/PmyYnb0b+v2xwnZFhZfgzXKO78Ic7e73FluC54l+NLCGp2a/xOun//ayynZ4J+oZbUvF8vbaZufA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777883191; c=relaxed/simple; bh=fLBrKN+ks85InWj6vqepemzsZfxfg7RV079GzSo1fT4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=PSEszAbDKigcy/UplSbZb1xBLFtgwzU2OYmobf22ibOg8SbQRTQjt5JAr9c7PxZzJr5TT+8zQRDEmhwz6Ec9xieqABD5KynweGu8lItRhW77NQD5a+Zi3I6BnmC+J6CqRuutobmUgKNg+RQRxl6JycQYFiylB+/n7h3/KhRtI8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=F1Hfsugc; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=R9N7f/T5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F1Hfsugc"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="R9N7f/T5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777883188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fLBrKN+ks85InWj6vqepemzsZfxfg7RV079GzSo1fT4=; b=F1HfsugcHBgPA64jIREmgRlBi8PU+l3omNRhvKqXaNG+wNjH9JMrIdIWIZip872j1xgQgS 8b5LanTON5yRokhvQ8bV4olMEzy3Ho1FfNOGjgIxjABekyuPLpS5irKb9fEOh4PJEjO/9W LiGcnU1ckJMkDvE38wdbEfCswFDZ3sI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-382-VaelpLJ_OwS5uaGJpTt6gg-1; Mon, 04 May 2026 04:26:26 -0400 X-MC-Unique: VaelpLJ_OwS5uaGJpTt6gg-1 X-Mimecast-MFC-AGG-ID: VaelpLJ_OwS5uaGJpTt6gg_1777883185 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48d046fac74so5226635e9.3 for ; Mon, 04 May 2026 01:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777883185; x=1778487985; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=fLBrKN+ks85InWj6vqepemzsZfxfg7RV079GzSo1fT4=; b=R9N7f/T537lvvhGSzcswL5qVWUWDDy0Q2r2mFsulzkTIuPzG70tACyfRSyCtcqkIgO VOMbNcUE/lM7f7P3WEN+/Ec8BL+ubBleN6eMMbqCUrc7PCcA0egcOTrz4Mw6aGkA9f0r yzyLvb15voCO7igRED2mJasaI5/vXLX6WixL/pERr8dFdOcpAEMWuTBpYqdO1WammpBa W72wqpRfASCpIDwBBwMQ02JFPHfpQesZmjlgcv6MNC1UIODnSKHpbkyJR7Z3fSwzMlou 28uEtagzJMZ7LsrABrUWIio9f36DXi+OpK0QsS3DYKZXL0ZVhGjQf1/G+jzhZl4sE3PU OVqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777883185; x=1778487985; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fLBrKN+ks85InWj6vqepemzsZfxfg7RV079GzSo1fT4=; b=S4eyJikvj5F6BSb7ToO+cjKqwW5CMYcUJdDQGa9Zgy17R38a2J4OFH/z+fh1gn+nIP uyrF/oj0TbiJeRXhqoR8WrdKU0kYv1kipaq4HBMdxrlGCzp0nPC3AN+NxJkUZDBbhUUB By2r18C5kQyrImruqQFY52K5QwTmRVz24Qqo+f6jYAK8DJYmKeUNuOaqWbXMm2eUMc2p dEMctFwu0IkFcyFFtoTADJa6Pu2j2cRzLZ9L5PySVKdSM0XGmDfC0+7zPq0/CKZFuw1t iFmK7NASETB/iwMK8aFci4iPHUn+0CjhzklNbNa/UavyHpOiEfihVr02DqcWCrl5q7r9 djkQ== X-Forwarded-Encrypted: i=1; AFNElJ+t4kYtTi1g2jizChfXArJ0O3kwnOP1x0IW/AaegmKkBmZLC1LserKOyyGYA2BNJDAMnJCnYAwLqi5VJc8=@vger.kernel.org X-Gm-Message-State: AOJu0YxGqY7YcJnZUpQj4qvP4DP366JafBGfo9YS7SsgAbOS0e36wtXf PWapTM70PBQ1bA2zla5vza3cR61WTlyHyTa5rlOhZ6h4TxsYVdjje5VbYWAy2HePsuJjzKw8Qv5 CRkAv2EfUAwgVKNJy7PFbN/BmMPWkDqfzyZcwvhEFYt43KAUMQBFl3MgAfRer9a959g== X-Gm-Gg: AeBDies3WG3Wbzc2FnogYZGWHlexw4WRF9xpR3P2v3n9VqxBgMNzMBE9V80s0eYglr/ ZwsZ5MKSTwjKt93TVIhklZ034q/0l4pCamdR+/2rKyLAOEsXyyfkoat1Y8X8X5QAjnuRwx4R8R9 cZ7VXpxCfw8wqaC1dmqbPl+lr+1iTCvhRpom5dSQgBbq+qawnZyPW9bO6ZR307AhkH0DWA/UXoN 7JE8SYzzpjlaox2+q/8yxmaILLWK+b0dXeyj+2EqAPuv9ebyyNlwwOOzyKyP4OBHXK6SvlyMVhw 53Vhx/IF4n6vAcwRe5TdPsu1coDkNR4kfMjACHbA4YXUoLUZcdj5rCOKUTc8yfWmaa9MIkgLM0D s8q6DrEqlbqFHnH5p0+0QGouY8NvPn6uCVBRkHg+us+xlTdn+fiv2eIFrhNnuDJ0Xgc516FM/BV BTBsgs2vvu3JKxuCHOA2w+VWGjqw== X-Received: by 2002:a05:600c:3f06:b0:485:3abe:ab86 with SMTP id 5b1f17b1804b1-48a9852cc0bmr146970315e9.4.1777883184737; Mon, 04 May 2026 01:26:24 -0700 (PDT) X-Received: by 2002:a05:600c:3f06:b0:485:3abe:ab86 with SMTP id 5b1f17b1804b1-48a9852cc0bmr146969775e9.4.1777883184345; Mon, 04 May 2026 01:26:24 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8fef2a67sm102134045e9.5.2026.05.04.01.26.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 01:26:23 -0700 (PDT) Message-ID: Subject: Re: [RFC PATCH 07/12] verification/rvgen: Add golden and spec folders for tests From: Gabriele Monaco To: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt Cc: Thomas Weissschuh , Tomas Glozar , John Kacur , Wen Yang Date: Mon, 04 May 2026 10:26:21 +0200 In-Reply-To: <878q9z1up7.fsf@yellow.woof> References: <20260427151134.192971-1-gmonaco@redhat.com> <20260427151134.192971-8-gmonaco@redhat.com> <878q9z1up7.fsf@yellow.woof> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-05-04 at 09:48 +0200, Nam Cao wrote: > I am working on converting rvgen to use Lark, a parsing library: > https://github.com/lark-parser/lark >=20 > This test case breaks the current version of the new script, because > state_c has no label while the script expects one - the script read the > state's name from the label. Right, good point, I forgot to add that.. Thanks for checking! > We should define if the label or the node's name is our state's > name. For example, if we have: >=20 > =C2=A0=C2=A0=C2=A0 "state_c" [label =3D "state_d"]; >=20 > Will the state's name be state_c or state_d? Or should that be a parsing > error? >=20 > I propose using the label if one is provided, otherwise using the node's > name. So >=20 > =C2=A0=C2=A0=C2=A0 "state_c" [label =3D "state_d"]; >=20 > means the state's name is "state_d". But without that statement, the > state's name is "state_c". >=20 > What do you think? Mmh, the only valid usecase I can think for DAs is to tweak the dot representation, e.g.: "state_c" [label =3D "State C"]; in this case the user might want to have a better display on the graph whil= e still keeping a valid state name. Also keep in mind that in HA we could do something like "state_c" [label =3D "state_c\nclk < 10"]; Here it's probably simpler to just parse the node name rather than the labe= l. Do you have any other reason to prefer "state_d" in your example? Either way we are opening for confusion (like in your example), so if you believe throwing an error makes the grammar simpler, we could also go down = that path. In any case, I would make the label definition mandatory. So my current sam= ple model is wrong. > (just FYI, my work-in-progress: > https://github.com/covanam/linux/commits/rv-lark/) Thanks for sharing, I'll have a look! Gabriele