[PATCH v2 2/3] arm64: dts: qcom: sm8250-xiaomi-pipa: Drop unused bq27z561

[PATCH v2 2/3] arm64: dts: qcom: sm8250-xiaomi-pipa: Drop unused bq27z561

[Arseniy Velikanov]

It looks like the fuel gauge is not connected to the battery,
it reports nonsense info. Downstream kernel uses pmic fg.

Reviewed-by: Luka Panio <lukapanio@gmail.com>
Signed-off-by: Arseniy Velikanov <me@adomerle.pw>
---
 .../boot/dts/qcom/sm8250-xiaomi-pipa.dts      | 22 -------------------
 1 file changed, 22 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts
index a4c8b778ae46..c2d0f0254776 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts
@@ -437,17 +437,6 @@ zap-shader {
 	};
 };
 
-&i2c0 {
-	clock-frequency = <400000>;
-	status = "okay";
-
-	fuel-gauge@55 {
-		compatible = "ti,bq27z561";
-		reg = <0x55>;
-		monitored-battery = <&battery_r>;
-	};
-};
-
 &i2c11 {
 	clock-frequency = <400000>;
 	status = "okay";
@@ -465,17 +454,6 @@ backlight: backlight@11 {
 	};
 };
 
-&i2c13 {
-	clock-frequency = <400000>;
-	status = "okay";
-
-	fuel-gauge@55 {
-		compatible = "ti,bq27z561";
-		reg = <0x55>;
-		monitored-battery = <&battery_l>;
-	};
-};
-
 &pcie0 {
 	status = "okay";
 };
-- 
2.50.0

Re: [PATCH v2 2/3] arm64: dts: qcom: sm8250-xiaomi-pipa: Drop unused bq27z561

[Dmitry Baryshkov]

On Wed, Jul 16, 2025 at 06:10:40PM +0400, Arseniy Velikanov wrote:
> It looks like the fuel gauge is not connected to the battery,
> it reports nonsense info. Downstream kernel uses pmic fg.

If you have to repost the patches for any reason, please sched more
light on the 'nosense' you are observing.

> 
> Reviewed-by: Luka Panio <lukapanio@gmail.com>
> Signed-off-by: Arseniy Velikanov <me@adomerle.pw>
> ---
>  .../boot/dts/qcom/sm8250-xiaomi-pipa.dts      | 22 -------------------
>  1 file changed, 22 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH v2 2/3] arm64: dts: qcom: sm8250-xiaomi-pipa: Drop unused bq27z561

[Konrad Dybcio]

On 7/16/25 4:59 PM, Dmitry Baryshkov wrote:
> On Wed, Jul 16, 2025 at 06:10:40PM +0400, Arseniy Velikanov wrote:
>> It looks like the fuel gauge is not connected to the battery,
>> it reports nonsense info. Downstream kernel uses pmic fg.
> 
> If you have to repost the patches for any reason, please sched more
> light on the 'nosense' you are observing.

Since it's actually onboard, it would be fair to assume it's there
for a reason.. Does it also report nonsense when running a
downstream build?

Konrad

Re: [PATCH v2 2/3] arm64: dts: qcom: sm8250-xiaomi-pipa: Drop unused bq27z561

[Arseniy Velikanov]

On 16.07.2025 20:00, Konrad Dybcio wrote:
> Since it's actually onboard, it would be fair to assume it's there
> for a reason.. Does it also report nonsense when running a
> downstream build?
Well, as I said before (looks like i sent reply wrongly), it's disabled
in the vendor's kernel config:
https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/pipa-t-oss/arch/arm64/configs/vendor/pipa_user_defconfig#L413

Also, pmic fuel gauge, which works with the WIP driver in our
close-to-mainline fork reports mixed information for a dual-cell
battery, instead of each cell individually, and I think
this is a more right way.

-- 
Kind regards,
Arseniy.

Re: [PATCH v2 2/3] arm64: dts: qcom: sm8250-xiaomi-pipa: Drop unused bq27z561

[Konrad Dybcio]

On 7/16/25 8:18 PM, Arseniy Velikanov wrote:
> On 16.07.2025 20:00, Konrad Dybcio wrote:
>> Since it's actually onboard, it would be fair to assume it's there
>> for a reason.. Does it also report nonsense when running a
>> downstream build?
> Well, as I said before (looks like i sent reply wrongly), it's disabled
> in the vendor's kernel config:
> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/pipa-t-oss/arch/arm64/configs/vendor/pipa_user_defconfig#L413
> 
> Also, pmic fuel gauge, which works with the WIP driver in our
> close-to-mainline fork reports mixed information for a dual-cell
> battery, instead of each cell individually, and I think
> this is a more right way.

OK this is a more convincing answer, thanks for confirming

Konrad