From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D13B31CB31D for ; Mon, 25 Nov 2024 22:39:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.60.130.6 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732574378; cv=none; b=fSM9D3i6FOhyCHq/IHWh3f4MUaO04vTRDbxTicL+zE8fdCgWRreK2chvl80VYhmMethL6GPHlNyUHRc38rWgQXStd+41MOFNOksO/g0beRcaE4qHfHZmaQab8o4eydgMurqOWEK+pkkNcW8H6lUHWUCi2XjDXdi1DvTgVoFpfiM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732574378; c=relaxed/simple; bh=qgYAYSNYik8WQa4WDmmcXRR66PKNlivw8pIGINLNgj0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rgaEw7qvPfx2B1yBV5MIk06ISZYXqASN93chzYe31Us2oTx90Kfd2RvXO9QrGF1miqQvo9i7MqVn1eqhQFqk/VYuN8jMFnI2UGxzEXGc39mRVhA+YegtGG0R66D/lrEJZDFI6agYwnGvn+Jsq8MJFx7ifZE3ukegds1ZAPSS+Nk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=dtT3Yhja; arc=none smtp.client-ip=178.60.130.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="dtT3Yhja" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WROCxlqoiJhEeQ478LkOeAF+oZmjtSUJgu3DBXtMWmM=; b=dtT3Yhja8j2ccplALLWMHelaK2 Ewqx9LdpUQEuP9wOvLvQYx1qhejBljV1p2Qy5dobGKVMuT9x2DaD8BmtmkXrZIOzTpBNA1HGKQ7sL 0in7rYf2nKIaVaU2epY38wobjYNT8NgEfD/9sYLorFeyanjbEysKd51eTfJjF1BNg9Cdl0vfaFWoP tN2s6NQD00TDvH+4Hc6aIJ3uLbSrGVC3KVk8knk1F2k7/vEUmHL3w7AjKCsDGYlHqphGv2CLUvnxT 54wSdgC7UeHZghq1v9m4fvjoCfjVEZPoKr3EC+h1T3qfMPBfGDLWXpn7qyMM/sdZcs705uEVldjIZ kndQ8aEw==; Received: from [187.36.213.55] (helo=[192.168.1.103]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1tFhjn-00Ct0k-B9; Mon, 25 Nov 2024 23:39:23 +0100 Message-ID: Date: Mon, 25 Nov 2024 19:39:14 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/5] drm/vkms: Switch to managed for crtc To: Louis Chauvet , Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Simona Vetter Cc: dri-devel@lists.freedesktop.org, arthurgrillo@riseup.net, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, nicolejadeyee@google.com References: <20241122-google-vkms-managed-v5-0-1ab60403e960@bootlin.com> <20241122-google-vkms-managed-v5-3-1ab60403e960@bootlin.com> Content-Language: en-US From: =?UTF-8?Q?Ma=C3=ADra_Canal?= In-Reply-To: <20241122-google-vkms-managed-v5-3-1ab60403e960@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Louis, On 22/11/24 13:27, Louis Chauvet wrote: > The current VKMS driver uses managed function to create crtc, but > don't use it to properly clean the crtc workqueue. It is not an > issue yet, but in order to support multiple devices easily, > convert this code to use drm and device managed helpers. > > Signed-off-by: Louis Chauvet > ---> drivers/gpu/drm/vkms/vkms_crtc.c | 14 ++++++++++++++ > drivers/gpu/drm/vkms/vkms_drv.c | 9 --------- > 2 files changed, 14 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c > index 28a57ae109fcc05af3fe74f94518c462c09119e3..ace8d293f7da611110c1e117b6cf2f3c9e9b4381 100644 > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > > #include "vkms_drv.h" > > @@ -270,6 +271,14 @@ static const struct drm_crtc_helper_funcs vkms_crtc_helper_funcs = { > .atomic_disable = vkms_crtc_atomic_disable, > }; > > +static void vkms_crtc_destroy_workqueue(struct drm_device *dev, > + void *raw_vkms_out) > +{ > + struct vkms_output *vkms_out = raw_vkms_out; > + > + destroy_workqueue(vkms_out->composer_workq); > +} > + > int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, > struct drm_plane *primary, struct drm_plane *cursor) > { > @@ -300,5 +309,10 @@ int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, > if (!vkms_out->composer_workq) > return -ENOMEM; > > + ret = drmm_add_action_or_reset(dev, vkms_crtc_destroy_workqueue, > + vkms_out); > + if (ret) > + return ret; > + Small nit: no need for `if (ret)` here. Anyway, Reviewed-by: Maíra Canal Best Regards, - Maíra > return ret; > } > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > index fa3331f612e34e0a48cef34effc169dea46d77df..c54504e590a18ae8af07cc1cc48179c38c4e6c0f 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.c > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > @@ -54,14 +54,6 @@ MODULE_PARM_DESC(enable_overlay, "Enable/Disable overlay support"); > > DEFINE_DRM_GEM_FOPS(vkms_driver_fops); > > -static void vkms_release(struct drm_device *dev) > -{ > - struct vkms_device *vkms = drm_device_to_vkms_device(dev); > - > - if (vkms->output.composer_workq) > - destroy_workqueue(vkms->output.composer_workq); > -} > - > static void vkms_atomic_commit_tail(struct drm_atomic_state *old_state) > { > struct drm_device *dev = old_state->dev; > @@ -109,7 +101,6 @@ static const struct drm_debugfs_info vkms_config_debugfs_list[] = { > > static const struct drm_driver vkms_driver = { > .driver_features = DRIVER_MODESET | DRIVER_ATOMIC | DRIVER_GEM, > - .release = vkms_release, > .fops = &vkms_driver_fops, > DRM_GEM_SHMEM_DRIVER_OPS, > DRM_FBDEV_SHMEM_DRIVER_OPS, >