From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v3 3/5] perf report: Sort by sampled cycles percent per block for stdio
Date: Wed, 23 Oct 2019 21:11:42 +0800 [thread overview]
Message-ID: <ffdcc12e-96ee-02f3-b327-93541af35f1a@linux.intel.com> (raw)
In-Reply-To: <20191023113642.GN22919@krava>
On 10/23/2019 7:36 PM, Jiri Olsa wrote:
> On Tue, Oct 22, 2019 at 04:07:08PM +0800, Jin Yao wrote:
>
> SNIP
>
>> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
>> index 43d1d410854a..eb286700a8a9 100644
>> --- a/tools/perf/util/sort.c
>> +++ b/tools/perf/util/sort.c
>> @@ -492,6 +492,10 @@ struct sort_entry sort_sym_ipc_null = {
>> .se_width_idx = HISTC_SYMBOL_IPC,
>> };
>>
>> +struct sort_entry sort_block_cycles = {
>> + .se_cmp = sort__sym_cmp,
>> +};
>
> so this is here only for you to be able to write '-s total_cycles'
> and has no other functonality right?
>
Yes, that's right.
> I think we'd be better with report boolean option instad, like
> 'perf report --total-cycles', because your code does the column
> display by itself.. and we could get rid of this -s confusion
>
Yes, I agree. Thanks for this suggestion!
Thanks
Jin Yao
> jirka
>
next prev parent reply other threads:[~2019-10-23 13:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 8:07 [PATCH v3 0/5] perf report: Support sorting all blocks by cycles Jin Yao
2019-10-22 8:07 ` [PATCH v3 1/5] perf util: Cleanup and refactor block info functions Jin Yao
2019-10-23 11:37 ` Jiri Olsa
2019-10-23 12:47 ` Jin, Yao
2019-10-22 8:07 ` [PATCH v3 2/5] perf util: Count the total cycles of all samples Jin Yao
2019-10-22 8:07 ` [PATCH v3 3/5] perf report: Sort by sampled cycles percent per block for stdio Jin Yao
2019-10-23 11:36 ` Jiri Olsa
2019-10-23 13:13 ` Jin, Yao
2019-10-23 11:36 ` Jiri Olsa
2019-10-23 13:11 ` Jin, Yao [this message]
2019-10-23 11:36 ` Jiri Olsa
2019-10-23 13:09 ` Jin, Yao
2019-10-23 14:27 ` Jiri Olsa
2019-10-23 14:46 ` Jin, Yao
2019-10-22 8:07 ` [PATCH v3 4/5] perf report: Support --percent-limit for total_cycles Jin Yao
2019-10-22 8:07 ` [PATCH v3 5/5] perf report: Sort by sampled cycles percent per block for tui Jin Yao
2019-10-23 11:36 ` Jiri Olsa
2019-10-23 12:54 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffdcc12e-96ee-02f3-b327-93541af35f1a@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox