linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [patch 1/3] LatencyTOP infrastructure patch
Date: Sun, 20 Jan 2008 12:34:49 +0100	[thread overview]
Message-ID: <fmvbkb$jmb$1@ger.gmane.org> (raw)
In-Reply-To: 20080118093943.0048d0f7@laptopd505.fenrus.org

Arjan van de Ven wrote:
> [linux-2.6.24-rc7/include/linux/latencytop.h]
> +struct latency_entry {
> +     char    *reason;
>...
> +struct latency_record {
> +     char    *reason;
>...
> +struct latency_entry *set_latency_reason(char *reason,
>...

I'd propose to mark the "reason" entries above (and the others as well)
as "const char *", which would move the strings to the ro-data section.

Helge


  reply	other threads:[~2008-01-20 11:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18 17:36 [Announce] Development release 0.1 of the LatencyTOP tool Arjan van de Ven
2008-01-18 17:39 ` [patch 1/3] LatencyTOP infrastructure patch Arjan van de Ven
2008-01-20 11:34   ` Helge Deller [this message]
2008-01-20 16:47   ` Dmitry Adamushko
2008-01-20 17:18     ` Dmitry Adamushko
2008-01-21  8:06   ` KOSAKI Motohiro
2008-01-21 16:16     ` Arjan van de Ven
2008-01-18 17:40 ` [patch 2/3] Latencytop instrumentations part 1 Arjan van de Ven
2008-01-18 22:26   ` Frank Ch. Eigler
2008-01-18 22:33     ` Arjan van de Ven
2008-01-18 22:47       ` Arnaldo Carvalho de Melo
2008-01-18 23:11       ` Frank Ch. Eigler
2008-01-18 23:20         ` Arjan van de Ven
2008-01-18 17:42 ` [patch 3/3] LatencyTOP instrumentations part 2 Arjan van de Ven
2008-01-18 18:27 ` [Announce] Development release 0.1 of the LatencyTOP tool Roberto Fichera
2008-01-18 18:35   ` Arjan van de Ven
2008-01-18 18:46     ` Roberto Fichera
2008-01-18 19:02 ` Zan Lynx
2008-01-19  5:07 ` Andi Kleen
2008-01-19  5:16   ` Arjan van de Ven
2008-01-19  5:27     ` Andi Kleen
2008-01-19  5:25       ` Arjan van de Ven
2008-01-19  5:33         ` Andi Kleen
2008-01-19  5:34           ` Arjan van de Ven
2008-01-19  6:08             ` Andi Kleen
2008-01-19  5:37           ` [Announce] Development release 0.1 of the LatencyTOP tool II Andi Kleen
2008-01-21  0:52 ` Development release 0.1 of the LatencyTOP tool KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='fmvbkb$jmb$1@ger.gmane.org' \
    --to=deller@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).