From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67D2A8F4A for ; Tue, 21 Apr 2026 01:08:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776733725; cv=none; b=XdxS8LwktgFdyzvoyJqYwsCsyVcBD/IbbDqEyPHm5vL+wjmiOnrP69cK3oKFS9B+UDM62hmPXTi9r0cf0fjC6oFqmLcTQSMj12Tu02MAfx56JSOnjmwZUG0X846S6RmINRxj3kCcrzw7RJyz5MWoPYtII4bcbC8+RE79qbf6++Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776733725; c=relaxed/simple; bh=7H9M3x3bqs69kmxhQDHyqH7H3xQvadbsg0DHK6NrJqE=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=egE8nw7lU4ePpfp1TOFq0UQTy2MblRAg3mwhT1MWGjTskDIymntnTR0/DhP2YyhtMjpFirzZishjSxr7n9MsEM7qHuaD7hD+EmRD4AT+P/Q0i+YA0qicj0/zGLcNg0pHl2Fb2Kkwsx9f+Webr5tQyrIpx0nvIbI0ZPt62FGg0TU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Up26EzHZ; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Up26EzHZ" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c736261ee8dso1286603a12.1 for ; Mon, 20 Apr 2026 18:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776733724; x=1777338524; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=7H9M3x3bqs69kmxhQDHyqH7H3xQvadbsg0DHK6NrJqE=; b=Up26EzHZ4+jn3nyVDrvYYa2sgCNvVlv67mMqKCS+2WbXNa/dSxesvYcA/3waUw3zuu W/S97p/afYzZ6+2VcKyXEbTAbNL+xse5mFesEAUpO06V0OFXqNgz6yI3+j3heTwHB7m/ rdi8X/L35+l00R3Rqidlp9HSmmftUdNMbG5UtqNg+HTl7ZEY1ce/5MBroJvPrRGuACbW VKua/LaTLXl/sYL5hwoilu5g8wgpFA3rRRfgq4+r2P4M2M/FXyqRmapA7zS+f5X2n9+7 dMA930idPl3sTU1iuTad+91n0PjEzkllRX/PE0aslnjaEE5Bo8etAUuOodFhj0BUH7WK aPlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776733724; x=1777338524; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7H9M3x3bqs69kmxhQDHyqH7H3xQvadbsg0DHK6NrJqE=; b=driH7r7u0tkqL4FNAv852jUFvBZHKhkIDoWS/MnB19SeA7Cy5BNaOnDdy0qc4QI4jw jyZyA+gLL2KuyPc3Q1eQhKxUdIzy+k7GxTvy/dCesvhXjB60TvViI4flnMa9iCn3SSsN qxdwApORvSVr16wfo/hT4RVW1LbGXDcz2lOPbdfyugc7Y+bQR5IHfmfOXdFOFdi4QnaD d1Y4kEYa2Wv/A4+MhnbjDy/1OaUWzPsOthBxlYjDm89BiZ/nSCADRcDh418b4m9dJFXu DammkC17JcMnHCGyYYmfo3cHGcH2oHamE3gslNBD2WORGJabMl1EUpdJng/ZvhIPi2gY 7FcQ== X-Forwarded-Encrypted: i=1; AFNElJ88nLrFBmBbdN0ThpRLfvUw/3/rOSk2tjplfymzVN8UTZ0giLnaTW9F9ZjcAncqYNtJwz996Q2d2T6hWN0=@vger.kernel.org X-Gm-Message-State: AOJu0YzYNKj57WyrFuGuP41STs9j1oHfr/mNqwLJJ4EWvl6xdYs+bixI AXDVzIdM3vK6+Z7BedlW/cyNX0/AkYuroapsww8LxAWVTZ85qCh1Kqyd X-Gm-Gg: AeBDieuXKGeOtyQG6/qxXZpVNi5QgZqD5joNJKqwir6ZnSpCf9b5s86gXehDVgmb1my ghb4xkzifxOGDe6s9qnWgaYwYYlDaxPKCtZXtz/jgroFYTv8Nc9f23wJm+TeOXU5L6NjOaaznGU vHvhy7QQG+jriVQw/iKP7LIbnFvv0R8LX19DoyEwcqnjGOYGOpCPYWX3AN3CaO0SJc4AXVO0FLz t6oDi1zANW0/VS5Ove7ZjLtpgaA9DmaALSl1fUB6BZpS8UNb0QdOAuo4YhLbyYz/cfNQTv5xONB sBXGpF/b2AL9EHp4TKiqI9jL9GoGKY6c4JgmvIGoxujhz/WPtD5YkXmTRy4dmN5CZCfgY8K/z7u 4VDezyuRs2o9Oo5he/+6vvgr2FKZ117lZmS1D2kkb/7m1fRBXaxDQons3Cc3vMQyhTRRkEQEmgr CK1RXp1xYu8cXp3RelcKvLCNrV/MQPsV1G X-Received: by 2002:a17:902:f78d:b0:2b2:67ca:5ff9 with SMTP id d9443c01a7336-2b5f9d888e8mr155879795ad.0.1776733723724; Mon, 20 Apr 2026 18:08:43 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab405f3sm114740025ad.78.2026.04.20.18.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 18:08:42 -0700 (PDT) From: Ritesh Harjani (IBM) To: Guangshuo Li , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Mahesh Salgaonkar , Haren Myneni , Tyrel Datwyler , Christian Brauner , Kees Cook , Guangshuo Li , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: Re: [PATCH v2] powerpc/pseries/papr-hvpipe: fix NULL dereference in handle creation In-Reply-To: <20260420132429.128075-1-lgs201920130244@gmail.com> Date: Tue, 21 Apr 2026 06:34:37 +0530 Message-ID: References: <20260420132429.128075-1-lgs201920130244@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Guangshuo Li writes: > papr_hvpipe_dev_create_handle() transfers ownership of src_info with > retain_and_null_ptr(src_info) after anon_inode_getfile() succeeds. > However, retain_and_null_ptr() clears src_info immediately, and the > function then still dereferences src_info in the subsequent list_add(). > > Store the transferred pointer in a separate variable and use that for > the list insertion. > > Manually identified during code review. Thanks. Although the fix for this and bunch of other fixes & cleanups were already queued up for review in here [1]. [1]: https://lore.kernel.org/all/cover.1775648406.git.ritesh.list@gmail.com/ -ritesh