From: Dmitry Baryshkov <dbaryshkov@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 0/0] Power domain and clock domain patches for omap
Date: Tue, 19 Aug 2008 21:46:00 +0000 (UTC) [thread overview]
Message-ID: <g8feuo$i9$1@ger.gmane.org> (raw)
In-Reply-To: 1216221555-18958-1-git-send-email-tony@atomide.com
Tony Lindgren wrote:
> Hi all,
>
> This patch series contains power domain and clock domain specific
> patches for omap posted to linux-arm-kernel list during 2.6.25-rc5.
>
> I'm reposting the series to a wider audience as Russell King suspected
> that other archs may be interested in reviewing these too, or at least
> some parts of the code.
>
> Please take a look and comment the code. Also please point out the
> pieces of code that may be suitable for your arch too!
There is one major flaw IMO in this code. Please correct me if I'm wrong:
Driver A: powerdomain_register()
Driver B: powerdomain_get()
Driver A: powerdomain_unregister()
Then Driver B has a reference to unregistered domain. And as powerdomains
lack any type of refcounting this can lead to any type of memory access
bugs if Driver A is unloaded from the kernel.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2008-08-19 21:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 15:19 [PATCH 0/0] Power domain and clock domain patches for omap Tony Lindgren
2008-07-16 15:19 ` [PATCH 01/10] ARM: OMAP2: Powerdomain: Add base OMAP2/3 powerdomain code Tony Lindgren
2008-07-16 15:19 ` [PATCH 02/10] ARM: OMAP2: Powerdomain: Add OMAP2/3 common powerdomains Tony Lindgren
2008-07-16 15:19 ` [PATCH 03/10] ARM: OMAP2: Powerdomain: Add OMAP2 powerdomains Tony Lindgren
2008-07-16 15:19 ` [PATCH 04/10] ARM: OMAP: Powerdomain: Add OMAP3 powerdomains Tony Lindgren
2008-07-16 15:19 ` [PATCH 05/10] ARM: OMAP2: Clockdomain: Add base OMAP2/3 clockdomain code Tony Lindgren
2008-07-16 15:19 ` [PATCH 06/10] ARM: OMAP2: Clockdomain: Connect clockdomain code to powerdomain code Tony Lindgren
2008-07-16 15:19 ` [PATCH 07/10] ARM: OMAP2: Clockdomain: Encode OMAP2/3 clockdomains Tony Lindgren
2008-07-16 15:19 ` [PATCH 08/10] ARM: OMAP2: Clockdomain: Associate clocks with clockdomains Tony Lindgren
2008-07-16 15:19 ` [PATCH 09/10] ARM: OMAP2: Clockdomain: Integrate OMAP3 clocks with clockdomain code Tony Lindgren
2008-07-16 15:19 ` [PATCH 10/10] ARM: OMAP2: Clock: Combine 34xx l3_icks and l4_icks Tony Lindgren
2008-07-21 22:29 ` [PATCH 0/0] Power domain and clock domain patches for omap Russell King - ARM Linux
2008-07-25 0:53 ` David Brownell
2008-08-19 21:46 ` Dmitry Baryshkov [this message]
2008-08-20 6:38 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='g8feuo$i9$1@ger.gmane.org' \
--to=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox